Load magnet url instead of searching #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrliou
reviewed
Nov 15, 2018
| @@ -25,7 +25,8 @@ BraveAutocompleteSchemeClassifier::GetInputTypeForScheme( | |||
| return metrics::OmniboxInputType::INVALID; | |||
| } | |||
| if (base::IsStringASCII(scheme) && | |||
| base::LowerCaseEqualsASCII(scheme, kBraveUIScheme)) { | |||
| (base::LowerCaseEqualsASCII(scheme, kBraveUIScheme) || | |||
| base::LowerCaseEqualsASCII(scheme, kMagnetScheme))) { | |||
There was a problem hiding this comment.
Could you check whether WebTorrent extension is enabled here, probably through ExtensionRegistry?
We could just use chromium's result when WebTorrent is disabled, and only change it when it is enabled, wdyt?
There was a problem hiding this comment.
Do you mean IsWebtorrentEnabled(profile) && base::LowerCaseEqualsASCII(scheme, kMagnetScheme)?
There was a problem hiding this comment.
I'm trying to include content_browser_client_helper.h in this cc file but I got some compile error. Did you intend this header should be only included in brave_content_browser_client.cc?
I'm curious why you implemented all methods in header.
There was a problem hiding this comment.
Done. IsWebtorrentEnabled() changed to api.
yrliou
added a commit
that referenced
this pull request
Nov 20, 2018
Load magnet url instead of searching
This was referenced Sep 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix brave/brave-browser#1435
Submitter Checklist:
npm test brave_unit_tests && npm test brave_browser_tests) ongit rebase master(if needed).git rebase -ito squash commits (if needed).Test Plan:
yarn test brave_browser_tests --filter=BraveContentBrowserClientTest.TypedMagnetURLReviewer Checklist: