Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid CNAME uncloaking if a proxy is set #9098

Merged
merged 1 commit into from
Jun 14, 2021
Merged

avoid CNAME uncloaking if a proxy is set #9098

merged 1 commit into from
Jun 14, 2021

Conversation

antonok-edm
Copy link
Collaborator

MANUAL Uplift of #8957
Fixes brave/brave-browser#16011

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@antonok-edm
avoid CNAME uncloaking if a proxy is set
31a7b4a 
second attempt, using ProxyConfigService approach

add GN dep and extract block to separate function

extra logging to debug windows issues

remove logging and CONFIG_PENDING fallback
@antonok-edm antonok-edm added this to the 1.26.x - Beta milestone Jun 11, 2021
@antonok-edm antonok-edm requested review from bbondy, darkdh and a team June 11, 2021 15:39
@antonok-edm antonok-edm requested a review from iefremov as a code owner June 11, 2021 15:39
@antonok-edm antonok-edm self-assigned this Jun 11, 2021
@antonok-edm antonok-edm merged commit bc4d851 into 1.26.x Jun 14, 2021
@antonok-edm antonok-edm deleted the manual_pr8957_proxy-disable-cname-uncloaking_1.26.x branch June 14, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iefremov iefremov iefremov approved these changes

@darkdh darkdh darkdh approved these changes

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@antonok-edm antonok-edm

Labels
None yet
Projects
None yet
Milestone
1.26.x - Release
Development

Successfully merging this pull request may close these issues.
3 participants
@antonok-edm @iefremov @darkdh