Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes ads are not shown due to round-robin not removing seen advertisers and/or ads #9571

Merged
merged 1 commit into from
Jul 28, 2021
Merged

Fixes ads are not shown due to round-robin not removing seen advertisers and/or ads #9571

merged 1 commit into from
Jul 28, 2021

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 27, 2021 •
edited by btlechowski
Loading

Resolves brave/brave-browser#17199
Resolves brave/brave-browser#15166

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See brave/brave-browser#17199

@tmancey tmancey self-assigned this Jul 27, 2021
@tmancey tmancey force-pushed the issues/17199 branch 3 times, most recently from cd541ec to 788bbc4 Compare July 27, 2021 22:13
@tmancey
Copy link
Collaborator Author

tmancey commented Jul 27, 2021

database_issue_17199.sqlite state from @jsecretan

moritzhaller
moritzhaller approved these changes Jul 28, 2021
View reviewed changes
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmancey tmancey requested a review from aseren July 28, 2021 13:17
@tmancey tmancey force-pushed the issues/17199 branch 2 times, most recently from 125e078 to 5b7ae4e Compare July 28, 2021 13:19
@tmancey tmancey merged commit b5086cc into master Jul 28, 2021
@tmancey tmancey deleted the issues/17199 branch July 28, 2021 21:58
@tmancey tmancey added this to the 1.29.x - Nightly milestone Jul 28, 2021
This was referenced Jul 29, 2021
Merged
Merged
@btlechowski
Copy link

Verification passed on

Brave 1.29.42 Chromium: 92.0.4515.115 (Official Build) nightly (64-bit)
Revision 48cb2f4029b84b003719740a6cf9ca73f374a857-refs/branch-heads/4515_105@{#4}
OS Linux

Verified Notification ad - GroupA - round robin from https://github.com/brave/internal/issues/762
Verified GroupA was used by the client:
image

Verified GroupA ad was shown:

[3688:3688:0731/060309.428307:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[3688:3688:0731/060309.428734:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[3688:3688:0731/060309.428889:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: 5865b3d8-c0f3-4fc6-891b-3589dab6edf0
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad - GroupA
  body: Ad - GroupA
  targetUrl: https://youtube.com
[3688:3688:0731/060309.433873:VERBOSE1:ads_service_impl.cc(1901)] Timeout ad notification with uuid 5865b3d8-c0f3-4fc6-891b-3589dab6edf0 in 120 seconds
[3688:3688:0731/060309.434355:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid 5865b3d8-c0f3-4fc6-891b-3589dab6edf0 and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[3688:3688:0731/060309.434822:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[3688:3688:0731/060309.435535:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid 5865b3d8-c0f3-4fc6-891b-3589dab6edf0 and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[3688:3688:0731/060309.436253:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[3688:3688:0731/060309.448572:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[3688:3688:0731/060309.448936:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[3688:3688:0731/060309.449221:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[3688:3688:0731/060309.451273:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/1f1f9f70-589e-41c3-a78f-cdc44de6b5c0/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiSWpEQWtzREhudHFRb2NYMXdwSTMyNXVCU2FJYlc0T0VqQUR2Y3BmN1JDcz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6ImF5UXF1dkl2UXFiK3M1YkVzcHc5VE8zTld6QnVCejZJekIzZklNOU9jQmV0aGZYSlBob1hSZXBISkZaTFltSVkzaWN5REptclVzcFE5MUhTNVNKVm5BPT0iLCJ0IjoiU1BONG94NElIVFFuaTN4MEcxY3VhVjVDSUNrSFN1UVJyZFBBUmIyV2FzYUNBaEFBTjJzY2VHU01TdlNxYVM5TnlDRUhMSWdiajN2UDIzSlV0MGFPTHc9PSJ9
  Content: {"blindedPaymentToken":"IjDAksDHntqQocX1wpI325uBSaIbW4OEjADvcpf7RCs=","buildChannel":"nightly","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[3688:3688:0731/060309.457015:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[3688:3688:0731/060309.463736:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[3688:3688:0731/060309.945826:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[3688:3688:0731/060309.945989:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/1f1f9f70-589e-41c3-a78f-cdc44de6b5c0/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwiSWpEQWtzREhudHFRb2NYMXdwSTMyNXVCU2FJYlc0T0VqQUR2Y3BmN1JDcz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6ImF5UXF1dkl2UXFiK3M1YkVzcHc5VE8zTld6QnVCejZJekIzZklNOU9jQmV0aGZYSlBob1hSZXBISkZaTFltSVkzaWN5REptclVzcFE5MUhTNVNKVm5BPT0iLCJ0IjoiU1BONG94NElIVFFuaTN4MEcxY3VhVjVDSUNrSFN1UVJyZFBBUmIyV2FzYUNBaEFBTjJzY2VHU01TdlNxYVM5TnlDRUhMSWdiajN2UDIzSlV0MGFPTHc9PSJ9
  Response Status Code: 201
  Response: {"id":"1f1f9f70-589e-41c3-a78f-cdc44de6b5c0","payload":{},"createdAt":"2021-08-01T22:06:39.826Z","type":"view","modifiedAt":"2021-08-01T22:06:39.826Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249"}
[3688:3688:0731/060309.946083:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[3688:3688:0731/060309.946140:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[3688:3688:0731/060309.946236:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/1f1f9f70-589e-41c3-a78f-cdc44de6b5c0/paymentToken
  Method: GET
[3688:3688:0731/060310.215263:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[3688:3688:0731/060310.215358:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/1f1f9f70-589e-41c3-a78f-cdc44de6b5c0/paymentToken
  Response Status Code: 200
  Response: {"id":"1f1f9f70-589e-41c3-a78f-cdc44de6b5c0","createdAt":"2021-08-01T22:06:39.826Z","type":"view","modifiedAt":"2021-08-01T22:06:39.858Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","paymentToken":{"publicKey":"bPE1QE65mkIgytffeu7STOfly+x10BXCGuk5pVlOHQU=","batchProof":"mLGVoeHp5S6wagpy2/JNCm5ZzEfLeKqKNUjwVvhPJA4XV5LrW/uOJasYVbDMPFsdr/kM40UgUZ0UdVLixd8ZDg==","signedTokens":["cNr7e7gLfVYoymJBm6rzygAvoy886keYbss0hWEI+TE="]}}
[3688:3688:0731/060310.215457:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 1f1f9f70-589e-41c3-a78f-cdc44de6b5c0, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and view
[3688:3688:0731/060310.216452:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 1 unblinded payment tokens

Verified the same GroupA ad was shown after round robin:

[4115:4115:0731/070624.627422:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[4115:4115:0731/070624.627560:VERBOSE1:client.cc(400)] Resetting seen ad_notification advertisers
[4115:4115:0731/070624.627991:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[4115:4115:0731/070624.628268:VERBOSE1:client.cc(370)] Resetting seen ad_notifications
[4115:4115:0731/070624.632063:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[4115:4115:0731/070624.632315:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[4115:4115:0731/070624.632631:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[4115:4115:0731/070624.636421:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: a9b874b9-fb32-4e59-9dc8-8e6cb75d262f
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad - GroupA
  body: Ad - GroupA
  targetUrl: https://youtube.com
[4115:4115:0731/070624.637832:VERBOSE1:ads_service_impl.cc(1901)] Timeout ad notification with uuid a9b874b9-fb32-4e59-9dc8-8e6cb75d262f in 120 seconds
[4115:4115:0731/070624.638279:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid a9b874b9-fb32-4e59-9dc8-8e6cb75d262f and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[4115:4115:0731/070624.638568:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[4115:4115:0731/070624.638922:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid a9b874b9-fb32-4e59-9dc8-8e6cb75d262f and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[4115:4115:0731/070624.639303:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[4115:4115:0731/070624.641106:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[4115:4115:0731/070624.641246:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[4115:4115:0731/070624.641382:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[4115:4115:0731/070624.641457:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/96f35f84-d45a-4b7c-b4dd-70d79b20a8da/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwieW5EWGZZV1NIWXhERXREY2llc2RkKzJ4a1JrSFJBdnpJMERlc0lla1hYST1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6Ik4rMjlSTlYzY2FTV3pEOXFDUFhrTmt0VDZvR05jU1l1T2N2WVhnYzQ4YzV6cmxMcmp0WURZNlhjaWNha3hES0dCZXB3ZGRWNzVZMVBBSUoxZHJvTUJRPT0iLCJ0IjoiRERBU1N4aW52QkE4UXp2VGM1YWRpS2pxYTBwOHgwQWoraklHemVzOXJ3YWR5OUNDTS9DM1JwVjltOUZua3A5M21IRjI0dWJMakcwM1BXdVNkV2xMa0E9PSJ9
  Content: {"blindedPaymentToken":"ynDXfYWSHYxDEtDciesdd+2xkRkHRAvzI0DesIekXXI=","buildChannel":"nightly","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[4115:4115:0731/070624.664011:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[4115:4115:0731/070624.668662:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[4115:4115:0731/070625.110487:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[4115:4115:0731/070625.110607:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/96f35f84-d45a-4b7c-b4dd-70d79b20a8da/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwieW5EWGZZV1NIWXhERXREY2llc2RkKzJ4a1JrSFJBdnpJMERlc0lla1hYST1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6Ik4rMjlSTlYzY2FTV3pEOXFDUFhrTmt0VDZvR05jU1l1T2N2WVhnYzQ4YzV6cmxMcmp0WURZNlhjaWNha3hES0dCZXB3ZGRWNzVZMVBBSUoxZHJvTUJRPT0iLCJ0IjoiRERBU1N4aW52QkE4UXp2VGM1YWRpS2pxYTBwOHgwQWoraklHemVzOXJ3YWR5OUNDTS9DM1JwVjltOUZua3A5M21IRjI0dWJMakcwM1BXdVNkV2xMa0E9PSJ9
  Response Status Code: 201
  Response: {"id":"96f35f84-d45a-4b7c-b4dd-70d79b20a8da","payload":{},"createdAt":"2021-08-01T22:10:06.179Z","type":"view","modifiedAt":"2021-08-01T22:10:06.179Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249"}
[4115:4115:0731/070625.110701:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[4115:4115:0731/070625.110790:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[4115:4115:0731/070625.110904:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/96f35f84-d45a-4b7c-b4dd-70d79b20a8da/paymentToken
  Method: GET
[4115:4115:0731/070625.307043:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[4115:4115:0731/070625.307177:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/96f35f84-d45a-4b7c-b4dd-70d79b20a8da/paymentToken
  Response Status Code: 200
  Response: {"id":"96f35f84-d45a-4b7c-b4dd-70d79b20a8da","createdAt":"2021-08-01T22:10:06.179Z","type":"view","modifiedAt":"2021-08-01T22:10:06.190Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","paymentToken":{"publicKey":"bPE1QE65mkIgytffeu7STOfly+x10BXCGuk5pVlOHQU=","batchProof":"h1NguMUFASBrZlrzLbAPrhQxSSd7tDNLzKjcr09E1wwWseA3qe4RORHrcjx+z7B5KKpY/2jk11mScLgEZpPoCQ==","signedTokens":["PB7atGjX8Hbu3R5A/Am1rZ8NRCsrkOdaP+Au9dxvjDE="]}}
[4115:4115:0731/070625.307294:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 96f35f84-d45a-4b7c-b4dd-70d79b20a8da, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and view
[4115:4115:0731/070625.307796:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 1 unblinded payment tokens

Verified upgrade scenario:
Confirmed round robin failed on 1.29.23

[1376:1376:0731/055558.591536:VERBOSE1:eligible_ad_notifications.cc(87)] Get eligible ads for parent-child segments:
[1376:1376:0731/055558.593063:VERBOSE1:eligible_ad_notifications.cc(89)]   untargeted
[1376:1376:0731/055558.594220:VERBOSE1:seen_advertisers.h(29)] All ad_notifications have been shown, so round robin
[1376:1376:0731/055558.594367:VERBOSE1:client.cc(400)] Resetting seen ad_notification advertisers
[1376:1376:0731/055558.595556:VERBOSE2:exclusion_rule_util.h(26)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[1376:1376:0731/055558.595756:VERBOSE1:eligible_ad_notifications.cc(100)] No eligible ads for parent-child segments
[1376:1376:0731/055558.595889:VERBOSE1:ad_notification_serving.cc(121)] Ad notification not served: No eligible ads found

Verified round robin worked after upgrade

[1954:1954:0731/055859.102152:VERBOSE1:seen_ads.h(29)] All ad_notifications have been shown, so round robin
[1954:1954:0731/055859.102232:VERBOSE1:client.cc(370)] Resetting seen ad_notifications
[1954:1954:0731/055859.104603:VERBOSE2:ad_priority.h(32)] 1 ads with a priority of 1 in bucket 1
[1954:1954:0731/055859.104950:VERBOSE1:ad_notification_serving.cc(126)] Found 1 eligible ads
[1954:1954:0731/055859.105076:VERBOSE1:ad_notification_serving.cc(222)] Serving ad notification:
  uuid: d6043106-c553-4d9c-9f98-507b46ef6fbf
  creativeInstanceId: 7898a259-664a-4052-8382-9c7279ae3249
  creativeSetId: 5e96fecc-2926-4c72-bb76-4e745bf6b539
  campaignId: 0d01425b-c970-4a25-b2d0-ccf748cfaf6e
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad - GroupA
  body: Ad - GroupA
  targetUrl: https://youtube.com
[1954:1954:0731/055859.106788:VERBOSE1:ads_service_impl.cc(1901)] Timeout ad notification with uuid d6043106-c553-4d9c-9f98-507b46ef6fbf in 120 seconds
[1954:1954:0731/055859.106939:VERBOSE3:ad_notification_event_served.cc(25)] Served ad notification with uuid d6043106-c553-4d9c-9f98-507b46ef6fbf and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[1954:1954:0731/055859.107043:VERBOSE1:ad_notification_serving.cc(137)] Served ad notification
[1954:1954:0731/055859.107194:VERBOSE3:ad_notification_event_viewed.cc(24)] Viewed ad notification with uuid d6043106-c553-4d9c-9f98-507b46ef6fbf and creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[1954:1954:0731/055859.107349:VERBOSE1:confirmations.cc(90)] Confirming view ad for creative instance id 7898a259-664a-4052-8382-9c7279ae3249
[1954:1954:0731/055859.111099:VERBOSE1:redeem_unblinded_token.cc(50)] Redeem unblinded token
[1954:1954:0731/055859.111312:VERBOSE1:redeem_unblinded_token.cc(64)] CreateConfirmation
[1954:1954:0731/055859.111452:VERBOSE2:redeem_unblinded_token.cc(65)] POST /v1/confirmation/{confirmation_id}/{credential}
[1954:1954:0731/055859.111586:VERBOSE5:redeem_unblinded_token.cc(69)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/6bcccbaa-a816-44c8-b604-010a94b40516/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwidENGazFweEtxU1MwYktIZ2FnQkNmVERRN2JpeFpIWEVuckR1SFV2N1pRbz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IjJYaXVMWEdlZmx1MWxJTS9oZVM0THdvL0JwRE5qb04rSERjK0kxNEZWZlk2RjI2TlB5Mk5zZmJvMElCYzVKREZTblI3SFhiSjhzU2lGblZWWTRzRzBnPT0iLCJ0IjoiNkI0RGNiMHZwQktoMTVNOVE1OEYxakx5Z0dkbUo1K1diWmpRVFdEdXoyWnBvMjhZTk04V3plYmRvamdXb2RjS1c0bkZZR3NFTWYrVkFrdUVwTE9ST2c9PSJ9
  Content: {"blindedPaymentToken":"tCFk1pxKqSS0bKHgagBCfTDQ7bixZHXEnrDuHUv7ZQo=","buildChannel":"nightly","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: POST
[1954:1954:0731/055859.128687:VERBOSE1:ad_notification_event_served.cc(33)] Successfully logged ad notification served event
[1954:1954:0731/055859.131307:VERBOSE6:ad_notification_event_viewed.cc(32)] Successfully logged ad notification viewed event
[1954:1954:0731/055859.604864:VERBOSE1:redeem_unblinded_token.cc(82)] OnCreateConfirmation
[1954:1954:0731/055859.605053:VERBOSE6:redeem_unblinded_token.cc(84)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/6bcccbaa-a816-44c8-b604-010a94b40516/eyJwYXlsb2FkIjoie1wiYmxpbmRlZFBheW1lbnRUb2tlblwiOlwidENGazFweEtxU1MwYktIZ2FnQkNmVERRN2JpeFpIWEVuckR1SFV2N1pRbz1cIixcImJ1aWxkQ2hhbm5lbFwiOlwibmlnaHRseVwiLFwiY3JlYXRpdmVJbnN0YW5jZUlkXCI6XCI3ODk4YTI1OS02NjRhLTQwNTItODM4Mi05YzcyNzlhZTMyNDlcIixcInBheWxvYWRcIjp7fSxcInBsYXRmb3JtXCI6XCJsaW51eFwiLFwic3R1ZGllc1wiOltdLFwidHlwZVwiOlwidmlld1wifSIsInNpZ25hdHVyZSI6IjJYaXVMWEdlZmx1MWxJTS9oZVM0THdvL0JwRE5qb04rSERjK0kxNEZWZlk2RjI2TlB5Mk5zZmJvMElCYzVKREZTblI3SFhiSjhzU2lGblZWWTRzRzBnPT0iLCJ0IjoiNkI0RGNiMHZwQktoMTVNOVE1OEYxakx5Z0dkbUo1K1diWmpRVFdEdXoyWnBvMjhZTk04V3plYmRvamdXb2RjS1c0bkZZR3NFTWYrVkFrdUVwTE9ST2c9PSJ9
  Response Status Code: 201
  Response: {"id":"6bcccbaa-a816-44c8-b604-010a94b40516","payload":{},"createdAt":"2021-08-01T22:02:29.423Z","type":"view","modifiedAt":"2021-08-01T22:02:29.423Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249"}
[1954:1954:0731/055859.605385:VERBOSE1:redeem_unblinded_token.cc(112)] FetchPaymentToken
[1954:1954:0731/055859.605515:VERBOSE2:redeem_unblinded_token.cc(113)] GET /v1/confirmation/{confirmation_id}/paymentToken
[1954:1954:0731/055859.605626:VERBOSE5:redeem_unblinded_token.cc(117)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/6bcccbaa-a816-44c8-b604-010a94b40516/paymentToken
  Method: GET
[1954:1954:0731/055859.862390:VERBOSE1:redeem_unblinded_token.cc(128)] OnFetchPaymentToken
[1954:1954:0731/055859.862474:VERBOSE6:redeem_unblinded_token.cc(130)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/6bcccbaa-a816-44c8-b604-010a94b40516/paymentToken
  Response Status Code: 200
  Response: {"id":"6bcccbaa-a816-44c8-b604-010a94b40516","createdAt":"2021-08-01T22:02:29.423Z","type":"view","modifiedAt":"2021-08-01T22:02:29.506Z","creativeInstanceId":"7898a259-664a-4052-8382-9c7279ae3249","paymentToken":{"publicKey":"bPE1QE65mkIgytffeu7STOfly+x10BXCGuk5pVlOHQU=","batchProof":"al4HU44twAy+qOVr+/ybIDwKjCVilBR1lRZXxPL1LgzfQN3fb20O3DxFzNsL0KkioH0H+EZYepKRRUS23vbFBQ==","signedTokens":["SjA2nC9a0pUuEcdLOLYdx7s5wUcNrpx4Fjfk44cThgM="]}}
[1954:1954:0731/055859.862555:VERBOSE1:confirmations.cc(250)] Successfully redeemed unblinded token with confirmation id 6bcccbaa-a816-44c8-b604-010a94b40516, creative instance id 7898a259-664a-4052-8382-9c7279ae3249 and view
[1954:1954:0731/055859.862897:VERBOSE1:confirmations.cc(273)] Added 1 unblinded payment token with an estimated redemption value of 0.05 BAT, you now have 1 unblinded payment tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moritzhaller moritzhaller moritzhaller approved these changes

@aseren aseren aseren approved these changes

@jsecretan jsecretan Awaiting requested review from jsecretan

Assignees

@tmancey tmancey

Labels
feature/ads
Projects
None yet
Milestone
1.29.x - Release
4 participants
@tmancey @btlechowski @moritzhaller @aseren