Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fixed crash on retrieving favicon for private tab (uplift to 1.30.x) #9973

Merged
merged 1 commit into from
Sep 5, 2021
Merged

[Android] Fixed crash on retrieving favicon for private tab (uplift to 1.30.x) #9973

merged 1 commit into from
Sep 5, 2021

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Sep 3, 2021 •
edited by kjozwiak
Loading

Uplift of #9972
Resolves brave/brave-browser#17657

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team September 3, 2021 14:52
@brave-builds brave-builds self-assigned this Sep 3, 2021
@brave-builds brave-builds added this to the 1.30.x - Beta milestone Sep 3, 2021
@samartnik samartnik added CI/skip-ios Do not run CI builds for iOS CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Sep 3, 2021
kjozwiak
kjozwiak approved these changes Sep 5, 2021
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.30.x approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per #9972 (comment).

@kjozwiak kjozwiak merged commit 9e29607 into 1.30.x Sep 5, 2021
@kjozwiak kjozwiak deleted the pr9972_android_crash_fix_1.30.x branch September 5, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Milestone
1.30.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @samartnik @brave-browser-releases