Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Duckduckgo popup for iPhone horizontal has wrong size. #322

Closed
iccub opened this issue Oct 9, 2018 · 2 comments · Fixed by #351
Closed

Duckduckgo popup for iPhone horizontal has wrong size. #322

iccub opened this issue Oct 9, 2018 · 2 comments · Fixed by #351
Labels
bug good first issue

Comments

@iccub
Copy link
Contributor

iccub commented Oct 9, 2018

zrzut ekranu 2018-10-9 o 16 38 35

This bug also happens in 1.6 codebase.
@iccub iccub added bug priority/P4 Planned work. We expect to get to it "soon". good first issue labels Oct 9, 2018
@tmancey tmancey removed the priority/P4 Planned work. We expect to get to it "soon". label Oct 10, 2018
@danielbogomazov
Copy link
Contributor

I can take a look at this if no one else is

@iccub
Copy link
Contributor Author

iccub commented Oct 15, 2018

Go for it @danielbogomazov :)

@danielbogomazov danielbogomazov mentioned this issue Oct 23, 2018
Merged
6 tasks
kylehickinson pushed a commit that referenced this issue Oct 25, 2018
@danielbogomazov @kylehickinson
Fix #322: Adjust height for popup when if it clips off screen
d3dee8a
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug good first issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #322: Adjust height for popup when if it clips off screen danielbogomazov/brave-ios
3 participants
@tmancey @iccub @danielbogomazov