Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Wallet: Auto-discovery of assets resets the visible assets pref #7443

Closed
nuo-xu opened this issue May 11, 2023 · 1 comment · Fixed by #7534
Closed

Wallet: Auto-discovery of assets resets the visible assets pref #7443

nuo-xu opened this issue May 11, 2023 · 1 comment · Fixed by #7534
Assignees
@nuo-xu
Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.56

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented May 11, 2023

iOS version of brave/brave-browser#28749
@nuo-xu nuo-xu added this to Web3 May 11, 2023
@nuo-xu nuo-xu self-assigned this May 12, 2023
@nuo-xu nuo-xu mentioned this issue Jun 1, 2023
Merged
11 tasks
@HEagle18 HEagle18 moved this to In Progress in Web3 Jun 2, 2023
nuo-xu added a commit that referenced this issue Jun 16, 2023
@nuo-xu
Fix #7443: Migrate User Assets from BraveCore to CoreData (#7534)
c737800
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jun 16, 2023
@iccub iccub added this to the 1.53 milestone Jun 16, 2023
@StephenHeaps StephenHeaps mentioned this issue Jun 20, 2023
Closed
@srirambv
Copy link
Contributor

Verification passed iPhone 7 with iOS 15.7.3 running 1.53 (23.7.6.16)

  • Verified steps from #7534
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list
  • Verified NFTs from the imported account shows up correctly
  • Verified hiding an NFT doesn't come back to NFT grid when browser is restarted

Verification passed iPhone 13 with iOS 16.5 running 1.53 (23.7.6.16)

  • Verified steps from #7534
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list
  • Verified NFTs from the imported account shows up correctly
  • Verified hiding an NFT doesn't come back to NFT grid when browser is restarted

Verification passed iPad Pro with iOS 16.6 Beta running 1.53 (23.7.6.16)

  • Verified steps from #7534
  • Verified disabling a token from visible list and importing a new account to trigger auto-discover doesn't add the disabled token to visible list
  • Verified NFTs from the imported account shows up correctly
  • Verified hiding an NFT doesn't come back to NFT grid when browser is restarted

@Uni-verse Uni-verse mentioned this issue Nov 10, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7443: Migrate User Assets from BraveCore to CoreD…
e845dbd 
…ata (brave/brave-ios#7534)
@StephenHeaps StephenHeaps mentioned this issue Jul 26, 2024
Merged
24 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
enhancement Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.56
Development

Successfully merging a pull request may close this issue.

Fix #7443: Migrate User Assets from BraveCore to CoreData brave/brave-ios
4 participants
@nuo-xu @iccub @srirambv @Uni-verse