Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Fix #3207: Migrate dependencies away from Carthage #3191

Merged
merged 24 commits into from
Jan 27, 2021
Merged

Fix #3207: Migrate dependencies away from Carthage #3191

merged 24 commits into from
Jan 27, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jan 12, 2021 •
edited
Loading

Summary of Changes

This pull request fixes #3207

Dependency New Home Old Version New Version Notes
SnapKit SPM 5.0.1 5.0.1 - Next Major
SDWebImage SPM 4.4.6 5.10.2 - Next Major
GCDWebServer SPM 3.5.2 ad60adf SPM package only existed on a fork which includes said update. ad60adf is 1 commit ahead of master and a few commits ahead of 3.5.4
onepassword-app-extension ThirdParty add-framework-support — SPM support unavailable, but repo is seldom updated.
XCGLogger SPM 7.0.0 7.0.1 - Next Major
Fuzi SPM 3.1.2 3.1.3 - Next Major
SwiftyJSON SPM 5.0.0 5.0.0 - Next Major
pop ThirdParty 1.0.12 — Project archived/no longer actively developed
Static ThirdParty 4.0.0 — SPM support unavailable, but repo is seldom updated.
lottie-ios SPM 1692cb4 3.1.9 - Next Major 3.1.9 includes change from 1692cb4
SwiftKeychainWrapper SPM 3.4.0 4.0.1
yubikit-ios SPM 3.0.0-Preview 3.2.0
adblock-rust ThirdParty 0.2.10 — Project is now compiled into an xcframework and can be updated from its directory
sqlcipher ThirdParty 3.20.1 3.4.2 Project is now compiled into an xcframework and can be updated from its directory

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson changed the title Death to carthage Migrate dependencies away from Carthage Jan 12, 2021
@kylehickinson kylehickinson force-pushed the death-to-carthage branch 2 times, most recently from 00087ae to 37b80cf Compare January 14, 2021 18:41
@kylehickinson kylehickinson changed the title Migrate dependencies away from Carthage Fix #3207: Migrate dependencies away from Carthage Jan 18, 2021
@kylehickinson kylehickinson linked an issue Jan 18, 2021 that may be closed by this pull request
Update Yubico lib to 3.1.0 #2781
Closed
@kylehickinson kylehickinson marked this pull request as ready for review January 25, 2021 21:12
@kylehickinson kylehickinson requested a review from iccub January 25, 2021 21:12
@kylehickinson kylehickinson requested review from jumde and a team January 25, 2021 21:12
soner-yuksel
soner-yuksel approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@soner-yuksel soner-yuksel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LETS GO! DEATH TO CARTHAGE!

@kylehickinson kylehickinson merged commit 5328e30 into development Jan 27, 2021
@kylehickinson kylehickinson deleted the death-to-carthage branch January 27, 2021 23:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jumde jumde jumde approved these changes

@soner-yuksel soner-yuksel soner-yuksel approved these changes

@iccub iccub Awaiting requested review from iccub

Assignees
No one assigned
Labels
needs security review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modernize dependency management Update Yubico lib to 3.1.0
3 participants
@kylehickinson @jumde @soner-yuksel