Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Ref #3177: Add more regions for Ecosia. #3213

Merged
merged 1 commit into from
Jan 20, 2021
Merged

Ref #3177: Add more regions for Ecosia. #3213

merged 1 commit into from
Jan 20, 2021

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Jan 19, 2021 •
edited
Loading

Summary of Changes

Related desktop ticket brave/brave-browser#13511

This pull request references #3177

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@iccub iccub added the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jan 19, 2021
@iccub iccub requested review from bsclifton and a team January 19, 2021 23:33
@iccub iccub added this to the 1.22.2 milestone Jan 19, 2021
@iccub iccub force-pushed the nobug/more_ecosia_regions branch from 646ac3c to 62259d7 Compare January 20, 2021 00:06
bsclifton
bsclifton suggested changes Jan 20, 2021
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment left; I think one was put by accident, otherwise LGTM! 😄

@iccub iccub force-pushed the nobug/more_ecosia_regions branch from 62259d7 to 490834a Compare January 20, 2021 10:45
@iccub
Copy link
Contributor Author

iccub commented Jan 20, 2021

@bsclifton thanks, removed 'BY', added it by mistake

@iccub iccub requested a review from bsclifton January 20, 2021 10:48
@iccub iccub removed the blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue label Jan 20, 2021
bsclifton
bsclifton approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 😄👌

@iccub iccub merged commit 5ea08b2 into development Jan 20, 2021
@iccub iccub deleted the nobug/more_ecosia_regions branch January 20, 2021 16:53
iccub added a commit that referenced this pull request Jan 20, 2021
@iccub
Ref #3177: Add more regions for Ecosia (#3213)
15a845a
@kjozwiak kjozwiak mentioned this pull request Jan 20, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

@Brandon-T Brandon-T Brandon-T approved these changes

@bsclifton bsclifton bsclifton approved these changes

@soner-yuksel soner-yuksel soner-yuksel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.22.2
Development

Successfully merging this pull request may close these issues.
5 participants
@iccub @kylehickinson @Brandon-T @bsclifton @soner-yuksel