Skip to content
This repository was archived by the owner on May 10, 2024. It is now read-only.

Fix #6011: Suppress 'switch to app' annoyances by default. #6054

Merged
merged 3 commits into from
Sep 28, 2022

Conversation

iccub
Copy link
Contributor

@iccub iccub commented Sep 23, 2022

Summary of Changes

This pull request fixes #6011

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. Fresh install
  2. Go to settings -> Brave Shields & Privacy, verify that 'Block 'Switch to App' Notices` is enabled by default.
  3. Go to reddit.com, verify that there's no 'switch to mobiel app' showing
  4. Disable the setting, go to reddit again and see if the popup is visible

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub marked this pull request as ready for review September 28, 2022 10:07
@iccub iccub requested review from cuba and a team September 28, 2022 10:11
Copy link
Contributor

@cuba cuba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...Mostly comments that are not strictly required except that we should remove the UUIDs and add a function that uses componentID

@iccub iccub requested a review from cuba September 28, 2022 11:45
@iccub iccub added this to the 1.44 milestone Sep 28, 2022
@iccub iccub merged commit 3f59b86 into development Sep 28, 2022
@iccub iccub deleted the bugfix/6011 branch September 28, 2022 13:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suppress Mobile “Switch to App” Annoyances
2 participants