This repository has been archived by the owner on May 13, 2024. It is now read-only.
Make "FAQ" link within "Add Funds" open a new tab #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
approved these changes
Oct 7, 2018
There was a problem hiding this comment.
@Bad-Science congrats on your first contribution! Looks good to me.
In order to get this in to the browser to resolve the issue in brave-browser, we'll need to update the brave-ui npm package. I don't have permissions to do this, but it will be done soon.
cc: @NejcZdovc
|
@ryanml sure we will merge couple of them today and I will make new version. @Bad-Science thanks for your contribution |
|
@ryanml @NejcZdovc My pleasure! Schedule permitting will be the first of many 🎉 Thank you for the quick and friendly replies and super fast merge! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves brave/brave-browser#1414 by adding a
target="_blank"to the FAQ link in the Add Funds modal.To test:
cc'ing @cezaraugusto as per the contributing page. Let me know if anything is out of order :)
Much love for this project <3