Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave Talk study to be in Release #119

Merged
merged 1 commit into from
Sep 22, 2021
Merged

Update Brave Talk study to be in Release #119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion seed/seed.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,7 +913,7 @@
}
],
"filter": {
"channel": ["BETA", "NIGHTLY"],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typically we should specify min_version, to not enable it for old clients @bsclifton @rebron

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also @kjozwiak

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iefremov can we get this fixed or is it too late at this point? What would happen if a client that ended up pulling the above study doesn't meet the new requirements. Would it simply be removed? Assuming it wouldn't cause any issues for users that meet the requirements and have the study?

I'll make sure we have a min_version next time 👍

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up - will do that going forward. No action needed for this, AFAIK. But they would be shown as being in an experiment which isn't applicable

"channel": ["RELEASE", "BETA", "NIGHTLY"],
"platform": ["WINDOWS", "MAC", "LINUX"]
}
}
Expand Down