Disable BraveCleanupSessionCookiesOnSessionRestore on MacOS. #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjozwiak
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Uplift into production approved after deliberating with @brave/uplift-approvers. QA has verified the PR on Nightly as per brave/brave-browser#29135 (comment) & #557 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brave restart after an update on MacOS doesn't work as expected. Because of this we cleanup session cookies when we shouldn't.
This PR restores the old behavior on MacOS until we fix the restart process.
brave/brave-browser#29135