add node env to crash reports

allow system crash reporter to run
run crash reporter for renderer on macos (this is only required for macos)
auditors: @bbondy @aekeus

app/crash-herald.js

@@ -11,7 +11,9 @@ exports.init = () => {
     companyName: 'Brave.com',
     submitURL: appConfig.crashes.crashSubmitUrl,
     autoSubmit: true,
-    ignoreSystemCrashHandler: true
+    extra: {
+      node_env: process.env.NODE_ENV
+    }
   }
   crashReporter.start(options)
 }

js/entry.js

@@ -21,6 +21,13 @@ require('../less/notificationBar.less')
 require('../less/addEditBookmark.less')
 require('../node_modules/font-awesome/css/font-awesome.css')
 
+if (process.platform === 'darwin') {
+  // Setup the crash handling for mac renderer processes
+  // https://github.com/electron/electron/blob/master/docs/api/crash-reporter.md#crashreporterstartoptions
+  const CrashHerald = require('../app/crash-herald')
+  CrashHerald.init()
+}
+
 const React = require('react')
 const ReactDOM = require('react-dom')
 const Window = require('./components/window')