Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Show default bookmark title for synced bookmarks
Browse files Browse the repository at this point in the history
Fix #7291

Test plan:
1. open pyramid 0, enable sync, bookmark something.
2. open pyramid 1, sync to pyramid 0, wait for the synced bookmark to appear.
3. click 'edit bookmark...' on the synced bookmark in pyramid 1. the title field should not be empty.
  • Loading branch information
diracdeltas committed Mar 2, 2017
1 parent e01a2a9 commit 57108ea
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion app/renderer/components/addEditBookmarkHanger.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,8 @@ class AddEditBookmarkHanger extends ImmutableComponent {
: (typeof location === 'string' && location.trim().length > 0)
}
get displayBookmarkName () {
if (this.props.currentDetail.get('customTitle') !== undefined) {
const customTitle = this.props.currentDetail.get('customTitle')
if (customTitle !== undefined && customTitle !== '') {

This comment has been minimized.

Copy link
@cndouglas

cndouglas Mar 14, 2017

customTitle !== '' prevents the user from completely clearing the title field. (#7691)

return this.props.currentDetail.get('customTitle')
}
return this.props.currentDetail.get('title') || ''
Expand Down

0 comments on commit 57108ea

Please sign in to comment.