Merge pull request #11947 from luixxiul/fix-faq-link

Replace End-User-FAQ link on preferences.js
brave · Nov 14, 2017 · 7024bff · 7024bff
2 parents 3968292 + 9d82248
commit 7024bff
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 14 deletions.
diff --git a/js/about/preferences.js b/js/about/preferences.js
@@ -164,10 +164,16 @@ class GeneralTab extends ImmutableComponent {
         </SettingItem>
         <div className='iconTitle'>
           <span data-l10n-id='myHomepage' />
-          <span className='fa fa-info-circle iconLink' onClick={aboutActions.createTabRequested.bind(null, {
-            url: 'https://github.com/brave/browser-laptop/wiki/End-User-FAQ#how-to-set-up-multiple-home-pages'
-          })}
-            data-l10n-id='multipleHomePages' />
+          <BrowserButton
+            iconOnly
+            iconClass={globalStyles.appIcons.moreInfo}
+            size='.95rem'
+            custom={styles.appIcons_moreInfo}
+            onClick={aboutActions.createTabRequested.bind(null, {
+              url: 'https://community.brave.com/t/how-to-set-up-multiple-home-pages/'
+            })}
+            l10nId='multipleHomePages'
+          />
         </div>
         <SettingItem>
           <SettingTextbox
@@ -980,6 +986,10 @@ class AboutPreferences extends React.Component {
 }
 
 const styles = StyleSheet.create({
+  appIcons_moreInfo: {
+    marginLeft: '5px'
+  },
+
   sitePermissions: {
     listStyle: 'none',
     margin: '20px'

diff --git a/less/about/preferences.less b/less/about/preferences.less
@@ -173,16 +173,8 @@ span.settingsListCopy {
     margin: 1.2em 2px 7px;
     color: #444444;
     font-size: 0.9em;
-
-    span {
-      display: inline-block;
-    }
-
-    .iconLink {
-      margin-left: 5px;
-      cursor: pointer;
-      vertical-align: middle;
-    }
+    display: flex;
+    align-items: center;
   }
 }