Don't change user bookmarks when site title changes

Fix #2209 Auditors: @aekeus
brave · Jun 23, 2016 · 88b6587 · 88b6587 · aekeus · Jun 23, 2016
1 parent e44d45e
commit 88b6587
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/js/state/siteUtil.js b/js/state/siteUtil.js
@@ -95,7 +95,9 @@ module.exports.addSite = function (sites, siteDetail, tag, originalSiteDetail) {
     lastAccessedTime: siteDetail.get('lastAccessedTime') || new Date().getTime(),
     tags,
     location: siteDetail.get('location'),
-    title: siteDetail.get('title')
+    // We don't want bookmarks and other site info being renamed on users if they already exist
+    // The name should remain the same while it is bookmarked forever.
+    title: oldSite && tags.includes(siteTags.BOOKMARK) ? oldSite.get('title') : siteDetail.get('title')
   })
   if (folderId) {
     site = site.set('folderId', Number(folderId))