Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Commit

Permalink
Remove unused code from #11040
Browse files Browse the repository at this point in the history
Auditors: @NejcZdovc
  • Loading branch information
bbondy committed Oct 3, 2017
1 parent e357db4 commit 9cfeae0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 12 deletions.
4 changes: 0 additions & 4 deletions app/common/state/bookmarksState.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,6 @@ const bookmarksState = {
return state.getIn([STATE_SITES.BOOKMARKS, key], Immutable.Map())
},

getBookmarkOrder: (state) => {
return state.getIn(STATE_SITES.BOOKMARK_ORDER_PATH)
},

/**
* Use this function if you only have a key and don't know if key is for folder or regular bookmark
* @param state
Expand Down
3 changes: 1 addition & 2 deletions js/constants/stateConstants.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,7 @@ const STATE_SITES = {
BOOKMARKS: 'bookmarks',
BOOKMARK_FOLDERS: 'bookmarkFolders',
HISTORY_SITES: 'historySites',
PINNED_SITES: 'pinnedSites',
BOOKMARK_ORDER_PATH: ['cache', 'bookmarkOrder']
PINNED_SITES: 'pinnedSites'
}

module.exports = {
Expand Down
6 changes: 0 additions & 6 deletions test/unit/app/common/state/bookmarksStateTest.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,6 @@ const stateWithData = Immutable.fromJS({
})

describe('bookmarkState unit test', function () {
describe('getBookmarkOrder', function () {
it('resturns order state', function () {
assert.deepEqual(bookmarksState.getBookmarkOrder(stateWithData), stateWithData.getIn(['cache', 'bookmarkOrder']))
})
})

describe('updateFavicon', function () {
it('updates the favicon for all matching entries', function () {
const processedState = bookmarksState.updateFavicon(stateWithData, 'https://brave.com/', 'https://brave.com/favicon.ico')
Expand Down

1 comment on commit 9cfeae0

@NejcZdovc
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Please sign in to comment.