Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Regression : Toolbar and UI Elements scale control is not working #10089

Closed
alexwykoff opened this issue Jul 21, 2017 · 9 comments · Fixed by #10578
Closed

Regression : Toolbar and UI Elements scale control is not working #10089

alexwykoff opened this issue Jul 21, 2017 · 9 comments · Fixed by #10578
Assignees
@bsclifton
Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include settings upstream
Milestone
0.18.x Hotfix 1 (...

Comments

@alexwykoff
Copy link
Contributor

alexwykoff commented Jul 21, 2017 •
edited by luixxiul
Loading

Test plan

#10578 (comment)

Steps to reproduce:

  1. Go to Preferences > Advanced
  2. Under "Toolbar and UI Elements scale", pick a different value from the drop down
  3. you'll be prompted to restart. Ignore this or click "no"
  4. Notice that the top area (where the URL bar is) hasn't changed in size
  5. Open a new window and notice the size is different
@cndouglas
Copy link

Maybe related: #9334

@bsclifton bsclifton added this to the 0.18.x (Beta Channel) milestone Jul 24, 2017
@bsclifton bsclifton self-assigned this Jul 24, 2017
@bsclifton
Copy link
Member

This works when you exit and relaunch- it's no longer taking immediate effect. Looking into why...

@bsclifton
Copy link
Member

Code path looks to be the same when you launch (and it gets set) versus setting once the browser is already loaded:

WebContents::SetZoomLevel
ZoomController::SetZoomLevel
ZoomController::SetZoomLevelByClient
> ZoomController::SetZoomLevelForHost

Will continue digging in

@bsclifton
Copy link
Member

bsclifton commented Jul 25, 2017 •
edited
Loading

It also seems that if the setting changes and then you create a new window, it will be the proper size

@bsclifton
Copy link
Member

bsclifton commented Jul 25, 2017 •
edited
Loading

This is a regression in Muon / Chromium- I can't repro the issue with Muon 4.1.9... but 4.3.0+ has the issue for sure.

@bsclifton bsclifton changed the title 0.18.x Regression : Toolbar and UI Elements scale control is not working Regression : Toolbar and UI Elements scale control is not working Jul 25, 2017
@bsclifton bsclifton mentioned this issue Jul 25, 2017
Closed
@bsclifton
Copy link
Member

Created #10132 as a work-around for 0.18.x. I think Chromium 60 upgrade is affecting this

cc: @hferreiro, @bridiver

@bsclifton bsclifton modified the milestones: 0.18.x hotfix, 0.18.x (Beta Channel) Jul 25, 2017
@bsclifton bsclifton removed their assignment Jul 25, 2017
@bridiver
Copy link
Collaborator

bridiver commented Aug 1, 2017

this needs STR

@bsclifton
Copy link
Member

@bridiver steps added 😄

@bsclifton
Copy link
Member

See notes in Chromium review by @bridiver for more info:
https://codereview.chromium.org/2888203006

@bsclifton bsclifton removed this from the 0.18.x Hotfix milestone Aug 1, 2017
@bsclifton bsclifton mentioned this issue Aug 18, 2017
Closed
@bsclifton bsclifton added this to the 0.18.x Hotfix (Release Channel) milestone Aug 18, 2017
@bsclifton bsclifton assigned bsclifton and unassigned bridiver Aug 18, 2017
@bsclifton bsclifton mentioned this issue Aug 18, 2017
Merged
8 tasks
NejcZdovc pushed a commit that referenced this issue Aug 18, 2017
@bsclifton @NejcZdovc
Don't prompt for restart when changing Toolbar and UI element scale (…
0460257 
…since the underlying problem was fixed)

Fixes #10089

Auditors: @luixxiul, @alexwykoff
NejcZdovc pushed a commit that referenced this issue Aug 18, 2017
@bsclifton @NejcZdovc
Don't prompt for restart when changing Toolbar and UI element scale (…
8bb3e28 
…since the underlying problem was fixed)

Fixes #10089

Auditors: @luixxiul, @alexwykoff
NejcZdovc pushed a commit that referenced this issue Aug 18, 2017
@bsclifton @NejcZdovc
Don't prompt for restart when changing Toolbar and UI element scale (…
29e874c 
…since the underlying problem was fixed)

Fixes #10089

Auditors: @luixxiul, @alexwykoff
This was referenced Aug 31, 2017
Closed
Closed
Closed
Closed
This was referenced Aug 31, 2017
Closed
Closed
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified regression release-notes/include settings upstream
Projects
None yet
Milestone
0.18.x Hotfix 1 (Release Channel)
Development

Successfully merging a pull request may close this issue.

Don't prompt for restart when changing Toolbar and UI element scale (…
7 participants
@bridiver @alexwykoff @kjozwiak @luixxiul @bsclifton @cndouglas @LaurenWags