Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Bloodhound improvements for start up time #10723

Closed
NejcZdovc opened this issue Aug 30, 2017 · 4 comments · Fixed by #10738
Closed

Bloodhound improvements for start up time #10723

NejcZdovc opened this issue Aug 30, 2017 · 4 comments · Fixed by #10738
Assignees
@NejcZdovc
Labels
perf QA/no-qa-needed release-notes/include
Milestone
0.20.x (Release C...

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Aug 30, 2017 •
edited
Loading

Describe the issue you encountered:
As described in #3025 (comment) bloodhound takes 3-4 seconds when starting up. We will save this with chunking sites into multiple intervals, this way we will not block startup time. Also we can remove fromJS() conversion and make bloodhound Immutable
@NejcZdovc NejcZdovc added the perf label Aug 30, 2017
@NejcZdovc NejcZdovc added this to the 0.21.x (Nightly Channel) milestone Aug 30, 2017
@NejcZdovc NejcZdovc self-assigned this Aug 30, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Aug 31, 2017
@NejcZdovc
Split bloodhounds initial add into chunks
c1507a0 
Resolves brave#10723

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Aug 31, 2017
Merged
8 tasks
@NejcZdovc NejcZdovc changed the title Add sites to bloodhound in chunks Bloodhound improvements for start up time Aug 31, 2017
bbondy added a commit that referenced this issue Sep 2, 2017
@bbondy
Merge pull request #10738 from NejcZdovc/hotfix/#10723-bloodhound
302b414 
Improvements for the startup time (Bloodhound)
@luixxiul
Copy link
Contributor

luixxiul commented Sep 2, 2017

needs-qa-test?

@luixxiul luixxiul added needs-info Another team member needs information from the PR/issue opener. release-notes/include QA/test-plan-required labels Sep 2, 2017
@bbondy
Copy link
Member

bbondy commented Sep 8, 2017

QA needed for this one yes, make sure suggestions work properly in general. Nejc can say more specifically.

@luixxiul luixxiul removed the needs-info Another team member needs information from the PR/issue opener. label Sep 8, 2017
@bbondy bbondy mentioned this issue Sep 18, 2017
Closed
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
@cezaraugusto
Copy link
Contributor

@NejcZdovc could you make a test plan for this so QA could validate? thanks!

@NejcZdovc
Copy link
Contributor Author

@cezaraugusto no specific QA steps. Just make sure that auto suggestion is working, which I think is already part of general pass

@kjozwiak kjozwiak mentioned this issue Jan 31, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
perf QA/no-qa-needed release-notes/include
Projects
None yet
Milestone
0.20.x (Release Channel)
Development

Successfully merging a pull request may close this issue.

Improvements for the startup time (Bloodhound) NejcZdovc/browser-laptop
5 participants
@bbondy @luixxiul @cezaraugusto @bsclifton @NejcZdovc