Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Blocked elements counts increase on shield by opening external links #11400

Closed
luixxiul opened this issue Oct 9, 2017 · 3 comments
Closed

Blocked elements counts increase on shield by opening external links #11400

luixxiul opened this issue Oct 9, 2017 · 3 comments
Labels
bug feature/shields priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Oct 9, 2017 •
edited
Loading

Description

Blocked elements counts of other tabs increase on the shield by opening external links.

Steps to Reproduce

  1. Install 0.19.36
  2. Open Manual test run on Linux for 0.19.x (Beta Channel) #11393
  3. Click http://slashdot.org/ to open the link in a new tab

Actual result:

The counts of the blocked elements increases on the GitHub page's tab. Click the gif image for larger one.

bug

Expected result:

It should not

Reproduces how often: [What percentage of the time does it reproduce?]

Consistently

Brave Version

about:brave info:

Brave: 0.19.36
rev: d24779f
Muon: 4.4.25
libchromiumcontent: 61.0.3163.100
V8: 6.1.534.41
Node.js: 7.9.0
Update Channel: Beta
OS Platform: Linux
OS Release: 4.9.0-3-amd64
OS Architecture: x64

Reproducible on current live release:

No.

Additional Information
@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Oct 9, 2017
@ghost ghost added the priority/P4 Minor loss of function. Workaround usually present. label Oct 9, 2017
@luixxiul luixxiul changed the title Blocked elements counts increases by opening external links Blocked elements counts increase on shield by opening external links Oct 9, 2017
@bsclifton
Copy link
Member

@luixxiul related? #2626

@luixxiul
Copy link
Contributor Author

no, that is a different issue.

bbondy added a commit that referenced this issue Oct 11, 2017
@bbondy
Blocked count should not update for background tabs
c0aea8f 
Fix #11400

Auditors: @bsclifton
bbondy added a commit that referenced this issue Oct 11, 2017
@bbondy
Blocked count should not update for background tabs
9459573 
Fix #11400

Auditors: @bsclifton
@bbondy bbondy closed this as completed in 2257e1d Oct 11, 2017
@bbondy
Copy link
Member

bbondy commented Oct 11, 2017

0.19.x: c0aea8f
0.20.x: 9459573
master: 2257e1d

syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@bbondy @syuan100
Blocked count should not update for background tabs
e8ecfeb 
Fix brave#11400

Auditors: @bsclifton
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug feature/shields priority/P4 Minor loss of function. Workaround usually present. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified regression release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
5 participants
@bbondy @luixxiul @bsclifton @srirambv @LaurenWags