Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

videos not displaying in ledger table properly after modifying Advanced Settings #11973

Closed
LaurenWags opened this issue Nov 15, 2017 · 4 comments

Comments

@LaurenWags
Copy link
Member

Description

Videos are not displayed properly (or sometimes at all) in ledger table after modifying advanced settings.

Steps to Reproduce

  1. Clean profile on 0.19.92
  2. Enable payments
  3. Modify Advanced Settings to be something like 5s/5visits.
  4. Visit at least 5 videos from the same channel for at least minimum amount of time.

Actual result:
I found that the channel was displayed in the table, but was missing 'Time Spent' as below. @srirambv found that his channel was never displayed in the ledger table at all.
screen shot 2017-11-15 at 11 16 00 am

Expected result:
Once video meets advanced settings it should be displayed in the table.

Reproduces how often:
Easily

Brave Version

about:brave info:
Brave | 0.19.92
rev | af635fb
Muon | 4.5.15

Reproducible on current live release:
no (n/a)

Additional Information

@srirambv
Copy link
Collaborator

STR on Windows

  1. clean install 0.19.92
  2. Change advance settings to 5sec/5visit
  3. Open any YT channel and play 5 videos for 1 min each
  4. No YT/channel details added to ledger

@LaurenWags
Copy link
Member Author

LaurenWags commented Nov 15, 2017

Additional STR:

  1. Clean profile on 0.19.92
  2. Enable payments
  3. Just modify one of the settings (i.e. 1minute/1visit)
  4. Watch 1+ minutes of a video, YT channel was not added to the ledger table.

@NejcZdovc NejcZdovc self-assigned this Nov 15, 2017
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Nov 15, 2017
Resolves brave#11973

Auditors:

Test Plan:
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Nov 15, 2017
Resolves brave#11973
Resolves brave#11972

Auditors:

Test Plan:
bsclifton added a commit that referenced this issue Nov 15, 2017
bsclifton added a commit that referenced this issue Nov 15, 2017
bsclifton added a commit that referenced this issue Nov 15, 2017
bsclifton added a commit that referenced this issue Nov 15, 2017
@kjozwiak
Copy link
Member

While going through this ticket, I ran into another case where the entry in the ledger table wasn't being displayed correctly.. The time spent was miscalculated my a large margin...

STR:

  • launch 0.19.95 and create/enable the wallet via about:preferences#payments
  • Click on the "Advanced" settings and select 1 minute & 1 visit
  • open a new tab and load https://www.youtube.com/watch?v=8-Cjsnq8kVU
  • let the video play for ~1.5 min, and switch over to about:preferences#payments

You'll notice that the "time spent" will be anywhere in the range of ~4-6mins when in reality you've only spent ~1minute on the video.

Platforms:

  • macOS 10.12.6 x64 using 0.19.95- Reproduced
  • Win 10 x64 using 0.19.95 - Reproduced
  • Ubuntu Ubuntu 17.04 x64 - Reproduced

Example:

screen shot 2017-11-15 at 11 55 03 pm

@NejcZdovc
Copy link
Contributor

closing this one as it's not related to the initial issue. @kjozwiak please open another issue for it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.