Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinning disabled publisher sets % value to 1 and not to actual value #12002

Closed
srirambv opened this issue Nov 16, 2017 · 1 comment
Closed

Pinning disabled publisher sets % value to 1 and not to actual value #12002

srirambv opened this issue Nov 16, 2017 · 1 comment
Labels
feature/rewards initiative/bat-payments priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion

Comments

@srirambv
Copy link
Collaborator

Description

Pinning disabled publisher sets % value to 1 and not to actual value

Steps to Reproduce

  1. Enable payments and visit 7-8 sites to add it in the ledger table
  2. Ensure each site has a decent amount of % value available
  3. Pin one of site with max time spent so that the major chunk of % value is set
  4. Pin second publisher which is enabled, ensure the % value remains as it was when it was enabled
  5. Exclude third publisher, ensure the % value is set to 0 from original calculated value
  6. Pin the excluded publisher, % value is set to 1
  7. Unpin the publisher pinned in step 6, shows actual value for %

Actual result:
pinned value1

Expected result:
Pinning excluded publisher should show the actual % value based on time visited and not set to 1

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.19.95
rev cc0ebad
Muon 4.5.16
libchromiumcontent 62.0.3202.94
V8 6.2.414.42
Node.js 7.9.0
Update Channel Release
OS Platform Microsoft Windows
OS Release 10.0.15063
OS Architecture x64

Reproducible on current live release:
Yes, same behaviour on 0.19.88
pinned value2

Additional Information

#11369 #11238 #10534
cc: @NejcZdovc @bsclifton

@srirambv srirambv added this to the Triage Backlog milestone Nov 16, 2017
@luixxiul luixxiul added the 0.19.x issue first seen in 0.19.x label Nov 21, 2017
@cezaraugusto cezaraugusto added the priority/P3 Major loss of function. label Nov 21, 2017
@bsclifton bsclifton modified the milestones: Triage Backlog, Prioritized Backlog Nov 21, 2017
@NejcZdovc NejcZdovc self-assigned this Feb 6, 2018
@NejcZdovc NejcZdovc added suggestion and removed 0.19.x issue first seen in 0.19.x bug priority/P3 Major loss of function. labels Feb 6, 2018
@NejcZdovc NejcZdovc removed their assignment Feb 6, 2018
@NejcZdovc
Copy link
Contributor

This is not a bug, we want to set it to 1%, because it was disabled so we don't know the real value that it has right now.

@NejcZdovc NejcZdovc added the priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). label Feb 6, 2018
@bsclifton bsclifton removed this from the Backlog (Prioritized) milestone Sep 3, 2018
@bsclifton bsclifton added the stale label Sep 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/rewards initiative/bat-payments priority/P5 Cosmetic. Spelling, copy, layout. New features (which should also be part of an initiative). stale suggestion
Projects
None yet
Development

No branches or pull requests

5 participants