Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Pinned publishers keeps getting auto unpinned #11369

Closed
srirambv opened this issue Oct 8, 2017 · 0 comments
Closed

Pinned publishers keeps getting auto unpinned #11369

srirambv opened this issue Oct 8, 2017 · 0 comments
Assignees
@NejcZdovc
Labels
bug feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.19.x (Beta Chan...

Comments

@srirambv
Copy link
Collaborator

srirambv commented Oct 8, 2017 •
edited by luixxiul
Loading

Test plan

#11384 (comment)

Description

Pinned publishers keeps getting auto unpinned

Steps to Reproduce

  1. Upgrade to 0.19.35
  2. Have three publishers pinned
  3. One at 90%, second at 4%, third at 4%
  4. Have one publisher enabled, set at 2% completing 100%
  5. Use browser normally for a while
  6. Open payments
  7. One of the pinned publisher with 4% is unpinned but still enabled

Actual result:

Pinned publishers keeps getting auto unpinned

Expected result:
Pinned publishers should remain pinned

Reproduces how often: [What percentage of the time does it reproduce?]
100%. Have seen this happen twice

Brave Version

about:brave info:

Brave 0.19.35
rev eda2732
Muon 4.4.25

Reproducible on current live release:

No

Additional Information

cc: @mrose17 @evq
@srirambv srirambv added bug feature/rewards priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. release/blocking labels Oct 8, 2017
@srirambv srirambv added this to the 0.19.x (Beta Channel) milestone Oct 8, 2017
@srirambv srirambv mentioned this issue Oct 8, 2017
Closed
NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue Oct 9, 2017
@NejcZdovc
Fixes auto unpinning for payment publishers
6def5b9 
Resolves brave#11369

Auditors:

Test Plan:
@NejcZdovc NejcZdovc mentioned this issue Oct 9, 2017
Merged
8 tasks
@ghost ghost added priority/P3 Major loss of function. and removed priority/P1 Blocks development or testing. Product cannot run. Must be fixed immediately, shipped next release. labels Oct 9, 2017
bsclifton added a commit that referenced this issue Oct 10, 2017
@bsclifton
Merge pull request #11384 from NejcZdovc/hotfix/#11369-unpinning
a03730a 
Fixes auto unpinning for payment publishers
bsclifton added a commit that referenced this issue Oct 10, 2017
@bsclifton
Merge pull request #11384 from NejcZdovc/hotfix/#11369-unpinning
be33dfc 
Fixes auto unpinning for payment publishers
bsclifton added a commit that referenced this issue Oct 10, 2017
@bsclifton
Merge pull request #11384 from NejcZdovc/hotfix/#11369-unpinning
a6e2dad 
Fixes auto unpinning for payment publishers
This was referenced Oct 12, 2017
Closed
Closed
syuan100 pushed a commit to syuan100/browser-laptop that referenced this issue Nov 9, 2017
@NejcZdovc @syuan100
Fixes auto unpinning for payment publishers
9f4ad50 
Resolves brave#11369

Auditors:

Test Plan:
This was referenced Nov 16, 2017
Closed
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@NejcZdovc NejcZdovc

Labels
bug feature/rewards priority/P3 Major loss of function. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.19.x (Beta Channel)
Development

No branches or pull requests
4 participants
@bsclifton @NejcZdovc @srirambv @LaurenWags