-
Notifications
You must be signed in to change notification settings - Fork 971
Formatting for Saved Site Exceptions (deleted YT channels) should match ledger table #12271
Comments
do you think that we need to update old (existing) entries as well or only new ones? |
Resolves brave#12271 Auditors: Test Plan:
@NejcZdovc I think it would be great if we could update the existing entries. WDYT @kjozwiak @srirambv @bsclifton ? |
Agreed would be good to have the existing entries updated. |
Resolves brave#12271 Auditors: Test Plan:
Resolves brave#12271 Auditors: Test Plan:
Resolves brave#12271 Auditors: Test Plan:
Resolves brave#12271 Auditors: Test Plan:
Resolves brave#12271 Auditors: Test Plan:
Fixes formatting for YT on shields page
Fixes formatting for YT on shields page
Fixes formatting for YT on shields page
Verified with macOS 10.12.6 using
Verified on Ubuntu 17.10 x64
|
@NejcZdovc if a YouTube or Twitch site was deleted in 0.22.669 and you update to 0.22.702, it displays as below. While this is more read-able than previously, it doesn't match what happens if you delete a site using 0.22.702 (see screenshot from #12271 (comment) ). Expected? |
@LaurenWags we set version value a long time ago and it was set to trigger upgrade if version is smaller then |
Just did some more testing and with the latest code that we have for 0.22 we can't preform upgrade for this case anymore, because we don't have information about the name. So this scenario is expected. |
Test Plan
See STR.
Also need to check ledger entries which were deleted in previous versions of Brave.
Description
After deleting a YT channel from your ledger table, if you go to re-add it under Shields > Saved Site Exceptions > Brave Payments, the YouTube channel is listed, the formatting doesn't match how the payments screen displays it.
Steps to Reproduce
Actual result:
![screen shot 2017-12-13 at 8 55 57 am](https://user-images.githubusercontent.com/28145373/33942286-73084a42-dfe3-11e7-85fd-b04446f0906c.png)
Formatting for site name doesn't display the way it does on ledger:
Expected result:
Formatting should match ledger for readability and in case user had accidentally removes one.
Reproduces how often:
Easily
Brave Version
about:brave info:
Brave | 0.19.115
rev | 584e694
Muon | 4.5.25
Reproducible on current live release:
yes
Additional Information
Similar to #12217
The text was updated successfully, but these errors were encountered: