Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

All publishers show same amount of time spent even if the time spent is more #13993

Closed
srirambv opened this issue May 2, 2018 · 3 comments
Closed

All publishers show same amount of time spent even if the time spent is more #13993

srirambv opened this issue May 2, 2018 · 3 comments
Assignees
@ryanml @NejcZdovc @jasonrsadler
Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression release-notes/exclude
Milestone
0.22.x Release 3 ...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 2, 2018

Description

All publishers show same amount of time spent even if the time spent is more

Steps to Reproduce

  1. Clean install 0.22.701
  2. Enable payments
  3. Visit sites in new tab and spend different on each page
  4. Each publisher on the table has the same amount of time spent.

Actual result:
All publishers show same amount of time spent even if the time spent is more

Expected result:
Should show the actual time spent

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.22.701
V8 6.6.346.26
rev 339ffd6
Muon 6.0.7
OS Release 10.0.16299
Update Channel Beta
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.139

Reproducible on current live release:
No

Additional Information

Issue confirmed on macOS by @LaurenWags
@srirambv srirambv added this to the 0.22.x Release 3 (Beta channel) milestone May 2, 2018
@ryanml ryanml self-assigned this May 2, 2018
@ryanml
Copy link
Contributor

ryanml commented May 2, 2018

@NejcZdovc I think I see what's happening with this, and it has to do with #13900

This issue is occurring when minimum visits are set to 1 and pageDataChanged is called to update the PublisherToggle status.

The problem is, that basically marks that visit as "Over" and only logs the minimum page time for that visit. Subsequent visits to the publisher log time just fine.

Once the call is made topageDataChanged I'll have to find a way to "Restart" that visit so that the time beyond the minimum is logged correctly.

ryanml added a commit to ryanml/browser-laptop that referenced this issue May 2, 2018
@ryanml
Fixes brave#13993, making sure extra time on first logged visit is no…
67f5d10 
…t ignored.
@ryanml ryanml mentioned this issue May 2, 2018
Merged
10 tasks
ryanml added a commit to ryanml/browser-laptop that referenced this issue May 3, 2018
@ryanml
Fixes brave#13993, making sure extra time on first logged visit is no…
b759283 
…t ignored.
@jasonrsadler
Copy link
Contributor

jasonrsadler commented May 3, 2018 •
edited
Loading

@jasonrsadler jasonrsadler self-assigned this May 3, 2018
ryanml added a commit to ryanml/browser-laptop that referenced this issue May 4, 2018
@ryanml
Fixes brave#13993, making sure extra time on first logged visit is no…
add2cf6 
…t ignored.
This was referenced May 8, 2018
Closed
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented May 8, 2018 •
edited by srirambv
Loading

Verified on Ubuntu 17.10 x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Verified with macOS 10.12.6 using

  • 0.22.703 903b8d0
  • muon 6.0.8
  • libchromiumcontent 66.0.3359.139

Verified on Windows x64

  • 0.22.703 903b8d0
  • libchromiumcontent 66.0.3359.139
  • muon: 6.0.8

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ryanml ryanml

@NejcZdovc NejcZdovc

@jasonrsadler jasonrsadler

Labels
bug feature/rewards QA/checked-Linux QA/checked-macOS QA/checked-Win64 regression release-notes/exclude
Projects
None yet
Milestone
0.22.x Release 3 (Release Channel)
Development

No branches or pull requests
6 participants
@ryanml @NejcZdovc @srirambv @jasonrsadler @LaurenWags @btlechowski