Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Visiting Netflix in a private tab shows Widevine notification on normal tabs #14227

Closed
srirambv opened this issue May 24, 2018 · 7 comments
Closed

Visiting Netflix in a private tab shows Widevine notification on normal tabs #14227

srirambv opened this issue May 24, 2018 · 7 comments
Assignees
@diracdeltas
Labels
bug feature/tor OS/macOS OS/Windows priority/P4 Minor loss of function. Workaround usually present. QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.23.x (Release C...

Comments

@srirambv
Copy link
Collaborator

srirambv commented May 24, 2018 •
edited
Loading

Description

Visiting Netflix in a private tab shows Widevine notification on normal tabs

Steps to Reproduce

  1. Install 0.23.7
  2. Open a private tor tab
  3. Visit Netflix, no widevine plugin notification is shown to enable it
  4. Switch to a normal tab, shows the widevine plugin notification for Netflix opened in a private tab

Actual result:
netflix

Expected result:
Should not show the notification in a normal tab for a site visited in private tab

Reproduces how often:
100%

Brave Version

about:brave info:

Brave 0.23.7
V8 6.6.346.32
rev f0e0dea
Muon 6.1.5
OS Release 10.0.17134
Update Channel Developer
OS Architecture x64
OS Platform Microsoft Windows
Node.js 7.9.0
Brave Sync v1.4.2
libchromiumcontent 66.0.3359.181

Reproducible on current live release:
N/A

Additional Information

cc: @diracdeltas @riastradh-brave
@srirambv srirambv added this to the 0.23.x (Developer Channel) milestone May 24, 2018
@alexwykoff alexwykoff added the priority/P4 Minor loss of function. Workaround usually present. label Jun 5, 2018
@alexwykoff
Copy link
Contributor

@flamsmark who might you traffic-cop this particular issue toward as it was introduced with the new private tabs?

@diracdeltas
Copy link
Member

are we sure this is a new issue? if so does it exist when tor is turned off?

@diracdeltas
Copy link
Member

i guess it's probably related to the fact that the widevine notification is supposed to not appear on Tor tabs (#13626)

@srirambv
Copy link
Collaborator Author

@diracdeltas yes based on #13626 it shouldn't prompt on tor tab or normal tab when you visit Netflix on a tor tab

@diracdeltas
Copy link
Member

assigning to myself since @flamsmark is busy with ads trial initiative

diracdeltas added a commit that referenced this issue Jun 14, 2018
@diracdeltas
Fix netflix notification from tor tabs appearing on normal tabs
c097adc 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
@diracdeltas
Copy link
Member

fixed by c097adc

petemill pushed a commit that referenced this issue Jun 15, 2018
@diracdeltas @petemill
Fix netflix notification from tor tabs appearing on normal tabs
32ef02a 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
55114c8 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
bsclifton pushed a commit that referenced this issue Jun 21, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
7b654d4 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
bsclifton pushed a commit that referenced this issue Jun 22, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
4033881 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
diracdeltas added a commit that referenced this issue Jun 22, 2018
@diracdeltas
Fix netflix notification from tor tabs appearing on normal tabs
6d141f2 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
bsclifton pushed a commit that referenced this issue Jun 23, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
152e4fd 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
This was referenced Jun 25, 2018
Closed
Closed
Closed
@srirambv
Copy link
Collaborator Author

srirambv commented Jun 25, 2018 •
edited by LaurenWags
Loading

Verified on Windows 10 x64 using

  • 0.23.16 - 2042c45
  • Muon - 7.1.1
  • libchromiumcontent - 67.0.3396.87
  • Seeing the below error similar to Tor browser
    image

Verified with macOS 10.12.6 using

  • 0.23.16 2042c45
  • Muon 7.1.1
  • libchromiumcontent 67.0.3396.87
  • seeing image above.

bsclifton pushed a commit that referenced this issue Jun 25, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
265d82a 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
@srirambv srirambv mentioned this issue Jun 25, 2018
Closed
bsclifton pushed a commit that referenced this issue Jun 26, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
0a0509d 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
bsclifton pushed a commit that referenced this issue Jun 27, 2018
@diracdeltas @bsclifton
Fix netflix notification from tor tabs appearing on normal tabs
c4f0c4e 
fix #14227

Test Plan:
1. open tor tab
2. go to https://www.netflix.com
3. you should not see a widevine notification.
4. switch back to a regular tab. no notification should appear.
5. open a non-tor tab and repeat step 2. you should see a widevine
   notification
@kjozwiak kjozwiak mentioned this issue Jun 27, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
bug feature/tor OS/macOS OS/Windows priority/P4 Minor loss of function. Workaround usually present. QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.23.x (Release Channel)
Development

No branches or pull requests
7 participants
@diracdeltas @tildelowengrimm @alexwykoff @kjozwiak @srirambv @LaurenWags @btlechowski