Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Move adblock-data s3 bucket to fastly #14608

Closed
RyanJarv opened this issue Jun 29, 2018 · 7 comments
Closed

Move adblock-data s3 bucket to fastly #14608

RyanJarv opened this issue Jun 29, 2018 · 7 comments

Comments

@RyanJarv
Copy link
Contributor

RyanJarv commented Jun 29, 2018

Test plan

  1. Close Brave
  2. Clear out .dat files in your profile directory
  3. Start brave, make sure it grabs the new .dat files and they appear in your profile directory again.
  4. Make sure regional lists still get downloaded if enabled.

Original issue description

This was done in master with the PR at https://github.com/brave/browser-laptop/pull/14254/files, however S3 is expensive and I should have set a milestone on it to get that released sooner.

Creating this ticket to have that pulled into the next release.

@NejcZdovc
Copy link
Contributor

Can this issue be closed based on #14254? Also here we set it to 0.23 release 2 but in PR there is 0.24?
which one should we do @petemill @RyanJarv ?

@bsclifton bsclifton self-assigned this Jul 2, 2018
@bsclifton
Copy link
Member

@NejcZdovc this is already merged to master / 0.24.x. I'll cherry-pick this into 0.23.x here in a moment...

@bsclifton
Copy link
Member

bsclifton commented Jul 2, 2018

Fixed with 02daa07

@RyanJarv do you mind adding some test steps for this? ex: once we have a build ready, how can we confirm (from your side) that we're hitting the CDN?

Found the test steps 😄 Adding to original post

@srirambv
Copy link
Collaborator

srirambv commented Jul 2, 2018

Verified on Windows 10 x64 using

  • 0.23.21 - 7240522
  • Muon - 7.1.4
  • libchromiumcontent - 67.0.3396.103

Verified with macOS 10.12.6 using

  • 0.23.21 7240522
  • Muon 7.1.4
  • libchromiumcontent 67.0.3396.103

Verified on Ubuntu 17.10 x64

  • 0.23.21 7240522
  • Muon 7.1.4
  • libchromiumcontent 67.0.3396.103

@petemill
Copy link
Member

Reverted via #14746 for reasons mentioned there.

@petemill petemill reopened this Jul 16, 2018
@bbondy
Copy link
Member

bbondy commented Jul 16, 2018

Turns out this was my bad, I thought etags weren't being returned and they are. This is ok. 🤦‍♂️

@kjozwiak
Copy link
Member

Re-adding the QA/Checked tags as per #14608 (comment). Since this has already beed tested with 0.23.37, there's no need to re-check it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.