This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
navigator.mediaDevices.enumerateDevices() returns too much info #14889
Assignees
Labels
fixed-with-brave-core
This issue will automatically resolved with the replacement of Muon with Brave Core.
privacy
QA/checked-Linux
QA/checked-macOS
QA/checked-Win64
QA/test-plan-specified
release/blocking
release-notes/include
security
Milestone
Comments
diracdeltas
added
fixed-with-brave-core
diracdeltas
added a commit
to brave/muon
that referenced
this issue
Aug 1, 2018
this basically reverts electron/electron@fce641a. the issue points out that this is needed for Electron apps to enumerate device labels. however, this is not supposed to be allowed unless permission is granted. potential fix for brave/browser-laptop#14889
diracdeltas
added a commit
that referenced
this issue
Aug 8, 2018
fix #14889 Test plan: 1. go to https://www.webrtc-experiment.com/DetectRTC/ 2. confirm that (1) the results are the same as what chrome shows on that site and (2) you see a permission prompt for media access 3. click 'remember this decision' and 'allow' on the permission prompt and reload the page. 4. confirm that in the "System has Speakers?" and "System has Microphone?" section, it now shows descriptions of all your devices.
10 tasks
diracdeltas
added a commit
that referenced
this issue
Aug 8, 2018
fix #14889 Test plan: 1. go to https://www.webrtc-experiment.com/DetectRTC/ 2. confirm that (1) the results are the same as what chrome shows on that site and (2) you see a permission prompt for media access 3. click 'remember this decision' and 'allow' on the permission prompt and reload the page. 4. confirm that in the "System has Speakers?" and "System has Microphone?" section, it now shows descriptions of all your devices.
This was referenced Aug 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Test plan
See #14970
Original issue description
STR:
test/fixturesand start a local server, ex: on port 8000Actual result: shows a description of every media device
Expected result: behaves the same as in Chrome (no device descriptions are shown, only an opaque ID).
Tested on MacOS, both master and current release (0.23.x).
The text was updated successfully, but these errors were encountered: