Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

[hackerone] chrome:// new tab issue #15045

Closed
jumde opened this issue Aug 16, 2018 · 5 comments · Fixed by #15047
Closed

[hackerone] chrome:// new tab issue #15045

jumde opened this issue Aug 16, 2018 · 5 comments · Fixed by #15047
Assignees
@diracdeltas
Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include sec-high security
Milestone
0.23.x Release 5 ...

Comments

@jumde
Copy link
Contributor

jumde commented Aug 16, 2018

https://hackerone.com/reports/395737
@jumde jumde added the security label Aug 16, 2018
@diracdeltas diracdeltas self-assigned this Aug 16, 2018
@diracdeltas diracdeltas changed the title [hackerone] #395737 [hackerone] chrome:// new tab issue Aug 16, 2018
@diracdeltas
Copy link
Member

DMing exploit to QA

diracdeltas added a commit that referenced this issue Aug 16, 2018
@diracdeltas
second fix for URL open in new tab
6595b82 
fix #15045

Test Plan:
DM'ed
@diracdeltas diracdeltas mentioned this issue Aug 16, 2018
Merged
10 tasks
@diracdeltas diracdeltas mentioned this issue Aug 21, 2018
Closed
@LaurenWags LaurenWags mentioned this issue Aug 21, 2018
Closed
@srirambv
Copy link
Collaborator

Verified on Windows 10 x64 using

  • 0.23.103 ae8e277
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@Metnew
Copy link

Metnew commented Aug 23, 2018 •
edited
Loading

The fix is incomplete. It only prevents navigation to chrome://${url} via "open in new tab", but it doesn't prevent resource loading through address bar.

@diracdeltas
Copy link
Member

This issue was only for the 'open in new tab' item; resource loading through URLbar is addressed in #15076

This was referenced Aug 23, 2018
Closed
Closed
@btlechowski
Copy link
Contributor

btlechowski commented Aug 23, 2018 •
edited by LaurenWags
Loading

Verified on Ubuntu 17.10 x64

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

Verified with macOS 10.12.6 using

  • 0.23.104 b454a4a
  • Muon 8.0.8
  • libchromiumcontent 68.0.3440.84

@kjozwiak kjozwiak mentioned this issue Aug 28, 2018
Closed
@kjozwiak kjozwiak mentioned this issue Sep 6, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@diracdeltas diracdeltas

Labels
QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include sec-high security
Projects
None yet
Milestone
0.23.x Release 5 (Release Channel)
Development

Successfully merging a pull request may close this issue.

second fix for URL open in new tab brave/browser-laptop
8 participants
@diracdeltas @tildelowengrimm @jumde @bsclifton @Metnew @srirambv @LaurenWags @btlechowski