Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow zoom for UI elements (including font size) #1937

Closed
luixxiul opened this issue May 27, 2016 · 9 comments
Closed

Allow zoom for UI elements (including font size) #1937

luixxiul opened this issue May 27, 2016 · 9 comments
Assignees
@bsclifton
Labels
accessibility design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Milestone
0.15.300 (Frozen,...

Comments

@luixxiul
Copy link
Contributor

luixxiul commented May 27, 2016 •
edited
Loading

Test plan

6527c55

From support

a top priority would be an option to change the font size for the UI. There are a lot of folks using fullHD screens (at minimum) and the dpi settings from windows does not seem to apply to Brave’s UI.

Could you add this on your priority list as in this moment, it is the only thing that stops me from using Brave (I can’t see the damn tabs – they are so small that I need glasses - or even better a magnifying glass - on a fullHD 15 inch screen)
@luixxiul luixxiul added design A design change, especially one which needs input from the design team. suggestion labels May 27, 2016
@ghost
Copy link

ghost commented May 27, 2016

It would be great to have such a feature, as there are people with eye issues around which are needing to increase UI font size to make the browser usable.

@bradleyrichter
Copy link
Contributor

I think we should be able to address this in a different way with resolution independence to fix the usability part. (automatic in Mac OS. Not sure about Windows versions.)

Later we can and normal/large UI fonts in prefs.

@srirambv srirambv mentioned this issue Sep 16, 2016
Closed
@luixxiul luixxiul mentioned this issue Sep 22, 2016
Closed
@bsclifton
Copy link
Member

Starting with 0.13.0, 125% DPI setting will actually be respected by Brave 😄

@bsclifton bsclifton changed the title Support fullHD and dpi setting Allow zoom for UI elements (including increasing font size) Feb 20, 2017
@bsclifton bsclifton changed the title Allow zoom for UI elements (including increasing font size) Allow zoom for UI elements (including font size) Feb 20, 2017
@bsclifton
Copy link
Member

bsclifton commented Feb 20, 2017 •
edited
Loading

Picture shared via Twitter:
image

NOTE: the user is showing that they'd like to DECREASE the size of the UI; but we should also be able to go over 100% too

@bradleyrichter
Copy link
Contributor

yes, this is from Vivaldi which does exactly what the "bug-now-feature" did from that old PR which needs "feature mining".

@bsclifton bsclifton mentioned this issue Mar 30, 2017
Closed
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned bsclifton Apr 2, 2017
@NejcZdovc NejcZdovc added this to the 0.14.3 milestone Apr 2, 2017
@bsclifton bsclifton assigned bsclifton and unassigned NejcZdovc Apr 4, 2017
@bsclifton
Copy link
Member

@NejcZdovc since you're working on ReduxComponent optimizations, I'll grab this one 😄

@MatthewS2077
Copy link

MatthewS2077 commented Apr 7, 2017 •
edited
Loading

Please someone fix this!
Being able to up-scale the UI is so important for "older" users who are running high DPI displays.
I've only just discovered Brave and I like it a lot BUT not being to up-scale the UI is the one thing that will make me switch back to Vivaldi.
Surely there are thousands of users who are turned off by not being able to up-scale the UI and never bother to complain and just uninstall Brave.

edit: Letting the user choose the UI font would also be nice! Not sure what UI font Brave is currently using but it's not very nice (imho).

@luixxiul
Copy link
Contributor Author

luixxiul commented Apr 9, 2017

the latter suggestion is being tracked here: #1757

bsclifton added a commit that referenced this issue Apr 21, 2017
@bsclifton
First stab at configurable UI scaling
3c8f2a6 
Doesn't affect page size; scaling is for the UI elements

Fixes #1937
bsclifton added a commit that referenced this issue Apr 21, 2017
@bsclifton
Break Preferences > Advanced into its own file; move the new zoom s…
a1a8164 
…etting there

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Settings should work as expected; there should be no console errors

Add configurable UI scaling. This doesn't affect page size; scaling is only for the browser UI elements

Fixes #1937

Auditors: @bradleyrichter, @alexwykoff, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Change the new `Toolbar and UI elements scale` setting.
  - verify default is `Normal`
  - choose a smaller size and verify URL bar, nav buttons, etc get smaller
  - choose a larger size and verify URL bar, nav buttons, etc get larger
  - verify size of page content does not change
@bsclifton bsclifton mentioned this issue Apr 21, 2017
Merged
4 tasks
bradleyrichter pushed a commit that referenced this issue Apr 21, 2017
@bsclifton @bradleyrichter
First stab at configurable UI scaling
35175ce 
Doesn't affect page size; scaling is for the UI elements

Fixes #1937
bsclifton added a commit that referenced this issue Apr 22, 2017
@bsclifton
Break Preferences > Advanced into its own file; move the new zoom s…
cef0d2a 
…etting there

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Settings should work as expected; there should be no console errors

Add configurable UI scaling. This doesn't affect page size; scaling is only for the browser UI elements

Fixes #1937

Auditors: @bradleyrichter, @alexwykoff, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Change the new `Toolbar and UI elements scale` setting.
  - verify default is `Normal`
  - choose a smaller size and verify URL bar, nav buttons, etc get smaller
  - choose a larger size and verify URL bar, nav buttons, etc get larger
  - verify size of page content does not change

This commit incorporates feedback from PR
- organize imports
- translations for the new drop down values
- moved "requires restart" style to commonStyles
- switch advancedTab to use aphrodite/no-important
- updated zoom values per convo w/ @bradleyrichter
bsclifton added a commit that referenced this issue Apr 23, 2017
@bsclifton
Break Preferences > Advanced into its own file; move the new zoom s…
046af3f 
…etting there

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Settings should work as expected; there should be no console errors

Add configurable UI scaling. This doesn't affect page size; scaling is only for the browser UI elements

Fixes #1937

Auditors: @bradleyrichter, @alexwykoff, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Change the new `Toolbar and UI elements scale` setting.
  - verify default is `Normal`
  - choose a smaller size and verify URL bar, nav buttons, etc get smaller
  - choose a larger size and verify URL bar, nav buttons, etc get larger
  - verify size of page content does not change

This commit incorporates feedback from PR
- organize imports
- translations for the new drop down values
- moved "requires restart" style to commonStyles
- switch advancedTab to use aphrodite/no-important
- updated zoom values per convo w/ @bradleyrichter
bsclifton added a commit that referenced this issue Apr 24, 2017
@bsclifton
Break Preferences > Advanced into its own file; move the new zoom s…
6527c55 
…etting there

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Settings should work as expected; there should be no console errors

Add configurable UI scaling. This doesn't affect page size; scaling is only for the browser UI elements

Fixes #1937

Auditors: @bradleyrichter, @alexwykoff, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Change the new `Toolbar and UI elements scale` setting.
  - verify default is `Normal`
  - choose a smaller size and verify URL bar, nav buttons, etc get smaller
  - choose a larger size and verify URL bar, nav buttons, etc get larger
  - verify size of page content does not change

This commit incorporates feedback from PR
- organize imports
- translations for the new drop down values
- moved "requires restart" style to commonStyles
- switch advancedTab to use aphrodite/no-important
- updated zoom values per convo w/ @bradleyrichter
- use new `DefaultSectionTitle` tag for the new AdvancedTab component
cezaraugusto pushed a commit that referenced this issue Apr 24, 2017
@bsclifton @cezaraugusto
Break Preferences > Advanced into its own file; move the new zoom s…
2212b33 
…etting there (#8419)

Auditors: @cezaraugusto, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Settings should work as expected; there should be no console errors

Add configurable UI scaling. This doesn't affect page size; scaling is only for the browser UI elements

Fixes #1937

Auditors: @bradleyrichter, @alexwykoff, @NejcZdovc

Test Plan:
1. Open preferences and visit the `Advanced` tab
2. Change the new `Toolbar and UI elements scale` setting.
  - verify default is `Normal`
  - choose a smaller size and verify URL bar, nav buttons, etc get smaller
  - choose a larger size and verify URL bar, nav buttons, etc get larger
  - verify size of page content does not change

This commit incorporates feedback from PR
- organize imports
- translations for the new drop down values
- moved "requires restart" style to commonStyles
- switch advancedTab to use aphrodite/no-important
- updated zoom values per convo w/ @bradleyrichter
- use new `DefaultSectionTitle` tag for the new AdvancedTab component
This was referenced May 2, 2017
Closed
Closed
Closed
Closed
@frank6tg
Copy link

frank6tg commented Apr 5, 2019

UI scaling should be completely separate from content on web page scaling.

@brave brave locked and limited conversation to collaborators Apr 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
accessibility design A design change, especially one which needs input from the design team. QA/checked-Linux QA/checked-macOS QA/checked-Win64 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.15.300 (Frozen, only critical adds ...
Development

No branches or pull requests
8 participants
@alexwykoff @luixxiul @frank6tg @bsclifton @NejcZdovc @bradleyrichter @srirambv @MatthewS2077