Pocket: Clicking Icon Does Nothing

[jonathansampson]

Describe the issue you encountered:
Clicking the Pocket Icon resulted in no login window.

Expected behavior:
Clicking the Pocket Icon should result in a login window, or a saved-url notification.

Explanation:
The showLoginWindow method fires a message to the extension. When the message is received, window.open is called. This call is suppressed.

I added a check for isChrome() to avoid calling window.open, as you'll see in the previous link.

• Platform: Windows 10
• Brave Version: 0.12.4

Repro Steps:
https://github.com/jonathansampson/browser-laptop/tree/ext_pocket

• Any related issues: Extension API: chrome.tabs.remove #4687 Pocket: Support ContentMenu Methods #4689 Pocket: chrome.app returns undefined at times #4692

[bridiver]

@jonathansampson are you sure it's trying to call window.open? If it is that's part of the problem because it should be calling chrome.tabs.create in the previous line

[darkdh]

I modified the auth.js to call chrome.tabs.create directly and it will open a login tab.

[darkdh]

isChrome requires window.chrome and window.chrome.app.
yeah it works with brave/muon@4f3eb57. but my auth.js of extension folder (version 2.1.7_0)copied chrome doesn't contain isChrome condition comparing to yours

[jonathansampson]

@bridiver @darkdh The method doesn't originally contain the isChrome() bit; I added that to avoid having to call window.open. Originally, the extension checks isSafari(), followed by isEdge(), followed by a fallback to window.open.

[bridiver]

I think Chrome must be passing that through as a user gesture somehow because it should be blocked otherwise