-
Notifications
You must be signed in to change notification settings - Fork 973
Add alert dialog for wallet backup invitation #4847
Comments
Moving to 0.13.7 |
@bradleyrichter should we use our regular alert or create a custom one? |
Normal alert is fine. We can improve the style for all alerts later.
… On Mar 25, 2017, at 7:43 AM, Nejc Zdovc ***@***.***> wrote:
@bradleyrichter should we use our regular alert or create a custom one?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
@bradleyrichter in mock user can only see backup now or remind me later, what if he doesn't want to see it at all? If we keep remind me later, when should we trigger it again? After another deposit? |
After each deposit made until backup is created.
… On Mar 26, 2017, at 5:04 AM, Nejc Zdovc ***@***.***> wrote:
@bradleyrichter in mock user can only see backup now or remind me later, what if he doesn't want to see it at all? If we keep remind me later, when should we trigger it again? After another deposit?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Resolves brave#4847 Auditors: Test Plan:
blocked by #8137 |
#8137 was merged. |
No longer blocked- see https://github.com/bsclifton/browser-laptop/blob/d1c662e1f4ec4460ba3e808d93f7fffe5e7a583b/app/browser/api/ledger.js#L231 for an example 😄 |
@mrose17 do we have any mechanism to detect when first contribution is made? |
@NejcZdovc - you'd have to look at the history for the earliest entry
|
blocked on #13504. This PR will introduce backup flag that we can then use in this PR |
@bradleyrichter do we still want to add this now that we added #13504 |
closing per discussion with @bradleyrichter |
When a user first adds funds to their auto-created Brave wallet, they should be invited to Backup their wallet. The dialog should open as a modal alert after they have completed the initial add-funds step.
cc @mrose17 @bbondy
The text was updated successfully, but these errors were encountered: