Add pref to allow Pinned tabs to function in single-window mode

[echosa]

Did you search for similar issues before submitting this one?

Yes

Describe the issue you encountered:

If I have tabs pinned in a window and open a new window, the pinned tabs are automatically loaded in the new window.

Expected behavior:

The new window should not have pinned tabs from other windows. Each window should have its own set of pinned tabs.

• Platform (Win7, 8, 10? macOS? Linux distro?):

OS X 10.11.6

• Brave Version:

0.12.10

• Steps to reproduce:

  1. Open a Brave window.
  2. Pin one or more tabs.
  3. Open a second Brave window.
  4. Notice that the pinned tabs are in the new Brave window.

• Any related issues:

Related to #3817

[bradleyrichter]

@echosa This is by design so I changed the title to reflect a request for a preference setting. Most of the feedback on how pinned tabs work differently has been positive but I can see adding an option to use the old approach.

Thanks for the feedback.

Brad

[cndouglas]

Suggestion from #7632: "have a windows id sct so that pinned tabs are not autoloaded in new windows. only load pinned tabs on the first window."

Two duplicates were set for 0.13.6, so I'll set this one accordingly.

[bsclifton]

+1 from user who DMed me

Pinned tabs are always pinned, across all windows. This made them unusable for me, since pinning to me is typically reserved for things that I want to keep open in a single session (I treat windows like sessions basically). So for instance, I have a window open right now with two pinned tabs, a JIRA board for work I'm doing, and a Pandora tab, because music. If I open a new window, I don't want a second instance of Pandora, and typically this new window would be for an entirely different session like testing a project I'm working on where the first window would be like searching SO for a fix for whatever I just did wrong.

[bsclifton]

Moving to 0.13.7

[bradleyrichter]

We should not load pinned tabs on non-active windows. @bbondy did some improvements here as well? I use pinned tabs like super-bookmarks and love having them on any window I have open and more importantly, new windows after I close all and start fresh. But I fully understand the pref for session-style windowing and pinning so we need a pref for this option.

…

On Mar 14, 2017, at 1:44 AM, Brian Clifton ***@***.***> wrote: Moving to 0.13.7 — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[bbondy]

most of the ground work for this is done but there are some problems with it still. I'm not sure if we'll get to this by 1.0 so I'm clearing the milestone for now. Pinned tabs work a lot better in general now though from various changes.

[bsclifton]

+1 from #8675

[srirambv]

Quite a few +1 from community https://community.brave.com/t/pinned-tabs-should-stay-in-the-window-they-were-pinned-in/1143/7

[luixxiul]

+1 from here: https://community.brave.com/t/cannot-unpin-tabs/2369/9?u=suguru

if the pinned tabs are just copied from the existing window instead of reloading on a new window, that would be not so critical.

[scottrepreneur]

+1 would be helpful

[altonf4]

+1 this would definitely help to avoid duplicate tabs and unnecessary memory usage. An option to enable this would be great!

[eljuno]

+1 from community https://community.brave.com/t/pinned-tabs-re-open-on-every-new-window/14097?u=eljuno

[gnarlyman]

+1 please add this option

[eljuno]

+1 from community https://community.brave.com/t/pinned-tab-behaviour-when-dragging-and-separating-a-non-pinned-tab-to-a-new-isolated-window/17553?u=eljuno

[NihilistZealot]

+1 from me as well, I've recently started using Brave and this 'feature' is jarring and not friendly. Additionally, why is it that pinned tabs are unable to be unpinned? Edit For some reason I was unable to unpin several tabs; the reason for this appears to have been the URL being altered when the pinned tab was unpinned resulting in the tab simply re-pinning over and over without being able to be deleted or unpinned as any new window would automatically re-open these tabs. Issue was found and resolved.

[echosa]

@NihilistZealot You're unable to unpin tabs that are pinned? Do you not see this when you right-click a pinned tab?

[laurencesmithever]

+1

[pettys]

+1. Chrome and Edge both work as +1'ers expect.

The current pinning behavior is confusing in this use case: I like to pin Pandora. If multiple windows are open, and they all have a Pandora tab, I wonder which one of them is actually playing the music right now.

The confusion shows up as bug: Today if I pin Pandora, switch to a non-pinned tab, then hit Ctrl+N to open a new window, Pandora stops playing, even though no Pandora window actually has focus right now. This makes pinned tabs unusable for Pandora. (Brave for Windows 0.22.13)

@bradleyrichter, regarding your comment a year ago supporting the current Brave pinning function, "I use pinned tabs like super-bookmarks and love having them on any window I have open and more importantly, new windows after I close all and start fresh." Does using pinned tabs in this way give you a significant advantage over using the bookmarks toolbar? I think there's an important technical difference between a bookmark and a pinned tab, and that technical/semantic difference is what the +1'ers here are reacting to.

Here's my Brave with both bookmarks and pinned tabs... they look pretty similar, but they mean very different things to me:

[bfinney-thoughtworks]

Another reason to want exactly 1 instance of each pinned tab: Many pages are resource-intensive. I don't want more copies of a high-CPU tab than are needed: when I pin it once, it should exist once and new windows should not attempt to have another running copy.

[eljuno]

+1 from Twitter https://twitter.com/shortstuffsushi/status/996892688782970886

[farmerdoe]

hi, is there any update on this? this is the one missing feature that is stopping me from using brave as my main browser

[bsclifton]

Hi folks - this issue has been fixed with Brave Core (the Chromium UI that we're working on which will replace our current Muon based product). For our current product, I think it's safe to say that we won't fix the issue ☹️ We anticipate the release of the new version in a few months time

[cndouglas]

+1 from https://medium.com/@PaulRBerg/constructive-feedback-for-the-brave-browser-9f08b422a05

[grezeaux]

I would also love to have pinned tabs only open on the first instance of opening the browser. I have six pinned tabs, and none of them are useful to have open multiple times (e.g., Gmail, JIRA, etc.).

[Ovadia-B]

This hack can open a new window without the pinned tabs.
Just run this JS code in Developer Tools console.
window.open("https://www.brave.com", "_blank", "width=400,height=400");

[bsclifton]

For folks subscribed to this or who find this page, we've recently launched the new version of our product 😄 (which fixes this issue) You can grab it here:
https://brave.com/download-dev