Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add delete confirmation to downloads bar #5969

Closed
bradleyrichter opened this issue Dec 1, 2016 · 1 comment
Closed

Add delete confirmation to downloads bar #5969

bradleyrichter opened this issue Dec 1, 2016 · 1 comment
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported parity Features which should be supported in Brave since they're supported in other major browsers.

Comments

@bradleyrichter
Copy link
Contributor

Deleting files is destructive and can not be undone. Thus, it needs a minimal confirmation.

Adding this to the delete bar UI keeps the confirmation focused at the point of interaction rather than opening a dialog.

To cancel, click outside of the popup box.

image
@bradleyrichter bradleyrichter added design A design change, especially one which needs input from the design team. enhancement parity Features which should be supported in Brave since they're supported in other major browsers. labels Dec 1, 2016
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Dec 1, 2016
@cndouglas cndouglas mentioned this issue Dec 2, 2016
Closed
@bsclifton bsclifton removed this from the 1.0.0 milestone Dec 3, 2016
@bsclifton
Copy link
Member

Closing as a duplicate of #2604

Love the pic! I copied it and your text over to #2604

@bsclifton bsclifton added the duplicate Issue has already been reported label Dec 3, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
design A design change, especially one which needs input from the design team. duplicate Issue has already been reported parity Features which should be supported in Brave since they're supported in other major browsers.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsclifton @bradleyrichter