-
Notifications
You must be signed in to change notification settings - Fork 972
Add delete confirmation to downloads bar #2604
Comments
An additional reason to add a confirmation here is because when downloading and you open the status-bar download box the "open in folder" is the last icon shown at the right. When the download completes the first icon on the left, "pause", is removed and a "delete" icon is added on the far right. This effectively replaces the "open in folder" icon with the "delete" icon in the same spot and nearly instantly when the remaining icons shift left to fill the hole left by the removal of the "pause" icon. Maybe change the icon order so that the pause is replaced by the delete, in the far left location, until the confirmation option is available? On the other hand it is nice to see that the delete icon can quickly remove a 4 GB ISO download that has just finished. :-( |
wdyt @bradleyrichter ? I noticed this too. |
+1, accidentally deleting downloads should be difficult imho
|
That would solve my problem completely and it looks pretty sharp too. |
Solution: #5969 |
from #5969, here are the acceptance criteria per @bradleyrichter:
|
Fixes brave#2604 Updated test to handle confirm click - rename downloadDeleteConfirmationVisible to deleteConfirmationVisible - wrap spy code with try/finally to ensure proper cleanup - confirmDeleteButton is checked independently from deleteButton Auditors: @michalbe
Fixes brave#2604 Updated test to handle confirm click - rename downloadDeleteConfirmationVisible to deleteConfirmationVisible - wrap spy code with try/finally to ensure proper cleanup - confirmDeleteButton is checked independently from deleteButton Auditors: @michalbe
Fixes brave#2604 Updated test to handle confirm click - rename downloadDeleteConfirmationVisible to deleteConfirmationVisible - wrap spy code with try/finally to ensure proper cleanup - confirmDeleteButton is checked independently from deleteButton Auditors: @michalbe
Fixes brave#2604 Updated test to handle confirm click - rename downloadDeleteConfirmationVisible to deleteConfirmationVisible - wrap spy code with try/finally to ensure proper cleanup - confirmDeleteButton is checked independently from deleteButton Auditors: @michalbe
Test Plan
downloadsBar
ok
to remove the filedownloadItem
panel to hide the confirmation bar.Original issue description
"Delete Download" on download bar should have a warning prompt.
The text was updated successfully, but these errors were encountered: