Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

cursor should be default on find bar (follow-up of #5744) #6812

Closed
luixxiul opened this issue Jan 22, 2017 · 6 comments
Closed

cursor should be default on find bar (follow-up of #5744) #6812

luixxiul opened this issue Jan 22, 2017 · 6 comments

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Jan 22, 2017

Test plan

#7161 (comment)


Describe the issue you encountered:

[1] While you move the mouse cursor on the find bar and the notification bar, keep pushing your mouse left button, the cursor should always be cursor:default. This is a follow-up of #5744.

[2] Any elements on the find bar and the notification bar should not be selected. The issue will be fixed by adding -webkit-user-select: none

  • Brave Version (revision SHA): 0.13.0 RC5

  • Steps to reproduce [1]:

    1. Open the find bar by pressing Ctrl-F
    2. Move the mouse cursor on the find bar, keep pushing your mouse left button
    3. Open https://www.google.com
    4. Move the cursor on the notification bar, keep pushing your mouse left button
  • Actual result [1]: cursor1

  • Expected result [1]: cursor2

  • Steps to reproduce [2]:

    1. Search something via the find bar
    2. Select the string x/x found or 0 matches
  • Actual result [2]: the string can be selected with the mouse

  • Expected result [2]: the string should not be selected

  • Any related issues: Findbar text selection #5744

@luixxiul luixxiul added feature/findbar polish Nice to have — usually related to front-end/visual tasks. suggestion labels Jan 22, 2017
@luixxiul
Copy link
Contributor Author

@bbondy If +1 plz feel free to assign me

@luixxiul
Copy link
Contributor Author

Also on .notificationBar:

cursor3

@bbondy
Copy link
Member

bbondy commented Jan 22, 2017

feel free to take things @luixxiul anytime! :)

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 4, 2017

Sorry I meant something different a bit. I will open another issue reopen this issue after editing the 1st comment later.

@luixxiul luixxiul reopened this Feb 4, 2017
@luixxiul luixxiul self-assigned this Feb 4, 2017
@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.2 Feb 4, 2017
@bbondy
Copy link
Member

bbondy commented Feb 4, 2017

It's best for the future to post a new issue for things that are different from the original issue, even if they are related. That way the thing that was valid and was fixed is properly referenced in release notes at the time it was fixed. The goal of the fix originally was meant to fix only what was reported which didn't involve pressing the left mouse button. Thanks!

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 4, 2017

ok I see.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants