This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 972
cursor should be default on find bar (follow-up of #5744) #6812
Labels
feature/findbar
misc/drag-and-drop
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
QA/test-plan-specified
release-notes/include
Milestone
Comments
luixxiul
added
feature/findbar
polish
Nice to have — usually related to front-end/visual tasks.
suggestion
labels
Jan 22, 2017
@bbondy If +1 plz feel free to assign me |
feel free to take things @luixxiul anytime! :) |
This was referenced Feb 3, 2017
Sorry I meant something different a bit. I will |
It's best for the future to post a new issue for things that are different from the original issue, even if they are related. That way the thing that was valid and was fixed is properly referenced in release notes at the time it was fixed. The goal of the fix originally was meant to fix only what was reported which didn't involve pressing the left mouse button. Thanks! |
ok I see. |
4 tasks
This was referenced Mar 1, 2017
This was referenced Mar 3, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
feature/findbar
misc/drag-and-drop
polish
Nice to have — usually related to front-end/visual tasks.
QA/checked-Linux
QA/checked-macOS
QA/checked-Win32
QA/checked-Win64
QA/test-plan-specified
release-notes/include
Test plan
#7161 (comment)
Describe the issue you encountered:
[1] While you move the mouse cursor on the find bar and the notification bar, keep pushing your mouse left button, the cursor should always be
cursor:default
. This is a follow-up of #5744.[2] Any elements on the find bar and the notification bar should not be selected. The issue will be fixed by adding
-webkit-user-select: none
Brave Version (revision SHA): 0.13.0 RC5
Steps to reproduce [1]:
Actual result [1]:
Expected result [1]:
Steps to reproduce [2]:
x/x found
or0 matches
Actual result [2]: the string can be selected with the mouse
Expected result [2]: the string should not be selected
Any related issues: Findbar text selection #5744
The text was updated successfully, but these errors were encountered: