Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Apply cursor:default and -webkit-user-select:none to .notificationBar… #7161

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Apply cursor:default and -webkit-user-select:none to .notificationBar… #7161

merged 1 commit into from
Feb 16, 2017

Conversation

luixxiul
Copy link
Contributor

… and .findBar

Also redundant decralations under .notificationBar and .findBar were removed

Closes #6812

Auditors: @bsclifton

Test Plan:

  1. Open https://google.com
  2. Move your mouse on the notification bar, keep pushing your mouse button
  3. Make sure the shape of the cursor does not change
  4. Open the find bar with CTRL+F
  5. Move your mouse on the find bar, keep pushing your mouse button
  6. Make sure the shape of the cursor does not change
  7. Input a string on the find bar
  8. Make sure the found results count and "Match case" is not selectable
  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).

… and .findBar

Also redundant decralations under .notificationBar and .findBar were removed.

Closes #6812

Auditors:

Test Plan:
1. Open https://google.com
2. Move your mouse on the notification bar, keep pushing your mouse button
3. Make sure the shape of the cursor does not change
4. Open the find bar with CTRL+F
5. Move your mouse on the find bar, keep pushing your mouse button
6. Make sure the shape of the cursor does not change
7. Input a string on the find bar
8. Make sure the found results count and "Match case" is not selectable
@luixxiul luixxiul added feature/findbar misc/drag-and-drop polish Nice to have — usually related to front-end/visual tasks. labels Feb 10, 2017
@luixxiul luixxiul added this to the 0.13.4 milestone Feb 10, 2017
@luixxiul
Copy link
Contributor Author

The area under .notificationBar will no longer be selectable:

screenshot 2017-02-10 18 18 45

@bbondy
Copy link
Member

bbondy commented Feb 16, 2017

++

@bbondy bbondy merged commit 0b4cb86 into brave:master Feb 16, 2017
@luixxiul luixxiul deleted the fix-findBarNotificationBar branch February 20, 2017 01:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/findbar misc/drag-and-drop polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants