Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

The Add Funds include button is enabled (or just displayed) on GitHub, Google #7089

Closed
luixxiul opened this issue Feb 6, 2017 · 13 comments
Closed

The Add Funds include button is enabled (or just displayed) on GitHub, Google #7089

luixxiul opened this issue Feb 6, 2017 · 13 comments
Assignees
@mrose17 @cezaraugusto
Labels
bug feature/rewards feature/URLbar QA/test-plan-specified release-notes/include
Milestone
0.13.5

Comments

@luixxiul
Copy link
Contributor

luixxiul commented Feb 6, 2017 •
edited by cezaraugusto
Loading

Test plan:

#7439 (comment)

Describe the issue you encountered: The Add Funds button is enabled (or just displayed) on GitHub.

The site is not listed on the ledger list on about:preferences#payments.

clipboard01

I cannot reproduce the issue with a fresh profile.

  • Platform (Win7, 8, 10? macOS? Linux distro?): Windows 10 32 bit

  • Brave Version (revision SHA): 0.13.2 RC6

  • Steps to reproduce:

    1. Open https://github.com

  • Actual result: The Add Funds include button is displayed

  • Expected result: It should not be displayed

  • Extra QA steps:
    1.
    2.
    3.

  • Screenshot if needed:

  • Any related issues:
@luixxiul luixxiul added this to the 0.13.4 milestone Feb 6, 2017
@srirambv
Copy link
Collaborator

srirambv commented Feb 6, 2017

I don't see it on fresh profile or after upgrade.

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 6, 2017

Me neither

@cezaraugusto
Copy link
Contributor

Couldn't reproduce as well.

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 6, 2017

@mrose17 if you need ledger files I could send them via DM. Please let me know, thanks.

@mrose17
Copy link
Member

mrose17 commented Feb 6, 2017

my guess is that there was an update to the publisher list. i've check the current list. i'm going to close this issue. if it re-appears, please let me know.

@luixxiul
Copy link
Contributor Author

luixxiul commented Feb 11, 2017 •
edited
Loading

@mrose17 I'm seeing the issue yet. how's the situation?

I got the icon on google.com as well.

clipboard01

@luixxiul luixxiul added the needs-info Another team member needs information from the PR/issue opener. label Feb 11, 2017
@luixxiul luixxiul changed the title The Add Funds include button is enabled (or just displayed) on GitHub The Add Funds include button is enabled (or just displayed) on GitHub, Google Feb 11, 2017
@cezaraugusto
Copy link
Contributor

Reproduced.

The issue is that synopsis list is allowing Google as a publisher. Add Funds toggle checks first for ledgerPayments (in this case, undefined) and synopsis list (in this case, true, that's why icon is shown).

It also shows on ledger:

screen shot 2017-02-11 at 1 59 38 pm

@mrose17 did we change something on ledger itself that changed synopsis list?

@luixxiul luixxiul modified the milestones: 0.13.3, 0.13.4 Feb 11, 2017
@luixxiul
Copy link
Contributor Author

I modified the milestones just in case.

@bbondy
Copy link
Member

bbondy commented Feb 14, 2017

@mrose17 mentioned this doesn't need to block 0.13.3 so I'm moving to 0.13.4.

@bbondy bbondy modified the milestones: 0.13.4, 0.13.3 Feb 14, 2017
@diracdeltas
Copy link
Member

I am also seeing the "Add Funds" button as enabled (orange heart) on github, google, facebook, etc.

@mrose17
Copy link
Member

mrose17 commented Feb 15, 2017 via email •
edited
Loading

@bbondy bbondy modified the milestones: 0.13.5, 0.13.6 Feb 15, 2017
@mrose17 mrose17 added this to the 0.13.5 milestone Feb 15, 2017
@cezaraugusto cezaraugusto self-assigned this Feb 16, 2017
@mrose17 mrose17 modified the milestones: 0.13.6, 0.13.5 Feb 28, 2017
@cezaraugusto cezaraugusto mentioned this issue Mar 1, 2017
Closed
cezaraugusto added a commit that referenced this issue Mar 2, 2017
@cezaraugusto
Update logic for publishers
69ed363 
Auditors: @mrose17, @bsclifton

Fix #7089
Fix #7429
@cezaraugusto cezaraugusto mentioned this issue Mar 2, 2017
Merged
4 tasks
@cezaraugusto cezaraugusto modified the milestones: 0.13.5, 0.13.6 Mar 2, 2017
@luixxiul luixxiul added QA/test-plan-specified release-notes/include and removed needs-info Another team member needs information from the PR/issue opener. labels Mar 2, 2017
This was referenced Mar 3, 2017
Closed
Closed
Closed
Closed
@alexwykoff
Copy link
Contributor

I'm still seeing google and github auto-enabled in master.

@cezaraugusto
Copy link
Contributor

@alexwykoff we're tracking that on: #7451

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrose17 mrose17

@cezaraugusto cezaraugusto

Labels
bug feature/rewards feature/URLbar QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.13.5
Development

No branches or pull requests
7 participants
@mrose17 @diracdeltas @bbondy @alexwykoff @luixxiul @cezaraugusto @srirambv