Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Define the behavior for default tiles on new tab page #7717

Closed
bsclifton opened this issue Mar 14, 2017 · 2 comments
Closed

Define the behavior for default tiles on new tab page #7717

bsclifton opened this issue Mar 14, 2017 · 2 comments
Assignees
@bsclifton @bradleyrichter
Labels
feature/newtab

Comments

@bsclifton
Copy link
Member

bsclifton commented Mar 14, 2017 •
edited
Loading

RELATED: Fresh Install of Brave Advertises Brave Properties #7655

I jumped the gun on approving that PR and it was merged. Let's understand what the stakeholders would like to see (we can hash out / propose here) and we'll make it happen 😄
@bsclifton bsclifton self-assigned this Mar 14, 2017
@bsclifton bsclifton added this to the 0.14.0 milestone Mar 14, 2017
@bsclifton bsclifton mentioned this issue Mar 14, 2017
Merged
4 tasks
@bsclifton bsclifton mentioned this issue Mar 16, 2017
Closed
bsclifton added a commit that referenced this issue Mar 16, 2017
@bsclifton
Revert changes made in #7692 until we have a plan of attack
e23e251 
(see #7717 for more info)

This PR:
- Reverts "Remove Brave software links from urlbar suggestions" (commit fa2eb80)
- Reverts "Since new list is cleared after a visit, let's not have any default pinned sites." (commit 34e6be4)
- Reverts "Actually remove Brave software links from history" (commit 3ef5da3)

Auditors: @diracdeltas, @bradleyrichter
@bsclifton bsclifton modified the milestones: 0.14.2, 0.14.0 Mar 16, 2017
@bsclifton
Copy link
Member Author

@bradleyrichter I reverted the changes @diracdeltas and I had made so everything is back to what it was like with prior versions. We can use this issue to hash out our plan (or stick with what we have 😄 )

@bsclifton bsclifton removed this from the 0.14.2 milestone Mar 22, 2017
@bsclifton
Copy link
Member Author

Closing this as it was fixed by @diracdeltas with #7753 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

@bradleyrichter bradleyrichter

Labels
feature/newtab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bsclifton @bradleyrichter