Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Reduce installer size #7896

Closed
bbondy opened this issue Mar 26, 2017 · 1 comment
Closed

Reduce installer size #7896

bbondy opened this issue Mar 26, 2017 · 1 comment
Assignees
@bbondy
Labels
installation QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Milestone
0.14.0

Comments

@bbondy
Copy link
Member

bbondy commented Mar 26, 2017 •
edited by bsclifton
Loading

Test plan

  1. Visit our releases page
  2. Compare the size with the last public release, 0.13.5
  3. Size for this release should be smaller

Original issue description

Reduce the installer size more.
@bbondy bbondy added this to the 0.14.0 milestone Mar 26, 2017
@bbondy bbondy self-assigned this Mar 26, 2017
@bbondy bbondy closed this as completed in ff34277 Mar 26, 2017
@bbondy
Copy link
Member Author

bbondy commented Mar 26, 2017

@bsclifton pls include this in 0.14.0

bsclifton pushed a commit that referenced this issue Mar 26, 2017
@bbondy @bsclifton
Reduce installer size by file types
8444734 
Auditors: @aekeus

Fix #7896

By ignoring by file type we can remove a lot of the redundant rules and catch things automatically as we add deps. I found this script on SO which lists all file types recursively

`find . -type f | perl -ne 'print $1 if m/\.([^.\/]+)$/' | sort -u | gvim`
http://stackoverflow.com/a/1842270/3153

After getting that list I exluded the things I think we need, and then
bisected when there was a problem starting the browser.
bbondy added a commit that referenced this issue Mar 26, 2017
@bbondy
Ignore non first level node_modules
fa91aab 
Auditors: @aekeus

Fix #7896
bbondy added a commit that referenced this issue Mar 26, 2017
@bbondy
Ignore non first level node_modules
790b7be 
Auditors: @aekeus

Fix #7896
@bsclifton bsclifton mentioned this issue Mar 27, 2017
Closed
@alexwykoff alexwykoff mentioned this issue Mar 28, 2017
Closed
44 tasks
@luixxiul luixxiul mentioned this issue Mar 29, 2017
Closed
This was referenced Mar 30, 2017
Closed
Closed
Closed
bridiver pushed a commit that referenced this issue Apr 4, 2017
@bbondy @bridiver
Ignore non first level node_modules
27a8b81 
Auditors: @aekeus

Fix #7896
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bbondy bbondy

Labels
installation QA/checked-Linux QA/checked-macOS QA/checked-Win32 QA/checked-Win64 QA/test-plan-specified release-notes/exclude
Projects
None yet
Milestone
0.14.0
Development

No branches or pull requests
5 participants
@bbondy @alexwykoff @luixxiul @bsclifton @srirambv