Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed accidental selection of lion badge numbers #7994

Closed
jonathansampson opened this issue Mar 30, 2017 · 0 comments
Closed

Fixed accidental selection of lion badge numbers #7994

jonathansampson opened this issue Mar 30, 2017 · 0 comments
Assignees
@bsclifton
Labels
bug design A design change, especially one which needs input from the design team. feature/adblock feature/shields feature/titlebar QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include
Milestone
0.14.1

Comments

@jonathansampson
Copy link
Collaborator

jonathansampson commented Mar 30, 2017 •
edited by bsclifton
Loading

Test Plan

  1. Click in the title-bar
  2. Press Ctrl+A
  3. Note the count is NOT selected

Original issue description

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    The block-count number is selectable.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    Desktop

  • Brave Version (revision SHA):
    0.14.0

  • Steps to reproduce:

    1. Click in the title-bar
    2. Press Ctrl+A
    3. Note the count is selected

  • Actual result:
    Count-numbers are selected.

  • Expected result:
    Count-numbers should not be selected.

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes

  • Is this an issue in the currently released version?
    Yes

  • Can this issue be consistently reproduced?
    Yes

  • Screenshot if needed:
    image

  • Any related issues:
@jonathansampson jonathansampson added bug design A design change, especially one which needs input from the design team. feature/adblock feature/shields feature/titlebar labels Mar 30, 2017
@jonathansampson jonathansampson added this to the 0.14.1 milestone Mar 30, 2017
@jonathansampson jonathansampson self-assigned this Mar 30, 2017
@alexwykoff alexwykoff mentioned this issue Mar 31, 2017
Closed
82 tasks
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.2 Mar 31, 2017
bsclifton added a commit that referenced this issue Mar 31, 2017
@bsclifton
Make lion badge text non-selectable
9307b0c 
Fixes #7994

Auditors: @jonathansampson

Test Plan:
1. Click in the title-bar
2. Press Ctrl+A
3. Note the count is NOT selected
This was referenced Apr 1, 2017
Closed
Closed
Closed
Closed
@alexwykoff alexwykoff changed the title Lion Badge Numbers are Selectable Fixed accidental selection of lion badge numbers Apr 1, 2017
bridiver pushed a commit that referenced this issue Apr 4, 2017
@bsclifton @bridiver
Make lion badge text non-selectable
7c8a9ca 
Fixes #7994

Auditors: @jonathansampson

Test Plan:
1. Click in the title-bar
2. Press Ctrl+A
3. Note the count is NOT selected
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
bug design A design change, especially one which needs input from the design team. feature/adblock feature/shields feature/titlebar QA/checked-macOS QA/checked-Win32 QA/test-plan-specified release-notes/include
Projects
None yet
Milestone
0.14.1
Development

No branches or pull requests
4 participants
@jonathansampson @alexwykoff @luixxiul @bsclifton