Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Tab audio icon doesn't show sometimes on non-active tabs #8249

Closed
bbondy opened this issue Apr 12, 2017 · 0 comments
Closed

Tab audio icon doesn't show sometimes on non-active tabs #8249

bbondy opened this issue Apr 12, 2017 · 0 comments

Comments

@bbondy
Copy link
Member

bbondy commented Apr 12, 2017

Test plan:

  • Indicator for audio must show if there's audio/video playing
  • Mute indicator must show show if there's audio/video playing
  • They should remain persistent while audio/video is playing

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    @cezaraugusto I'm still getting intermittently audio icon only showing on hover and when active. I don't have consistent steps but it definitely happens sometimes on facebook.com. It will not show an audio icon when a video is playing, and then when I hover over it to preview the tab then it comes up.

I suspect something in one of these props from tabContents.js
return this.pageCanPlayAudio && !this.mediumView && !this.narrowView

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    macOS, probably everywhere though.

  • Brave Version (revision SHA):
    61ae1a7

  • Steps to reproduce:
    Not consistent but...

    1. Login to facebook, play a video
    2. Open a bunch of other tabs
    3. when other tabs are focused, it can eventually get in a state where facebook's tab will only show the audio icon when previewed or hovered
  • Actual result:
    Audio icon is sometimes hidden on non active tabs. There is no audio blue bar either.

  • Expected result:
    Audio icon should always be visible (or the audio blue bar indicator if the tabs are small)

  • Will the steps above reproduce in a fresh profile? If not what other info can be added?
    Yes, but you do have to play around with it for a few minutes before getting it. And it will sometimes start working again intermittently. I think it maybe gets 2 tabs confused in props or something. Like maybe the Facebook tab gets the audio status of the active tab instead of its own.

  • Is this an issue in the currently released version?
    I don't think so.

  • Can this issue be consistently reproduced?
    Not consistently but I've seen it several times since using the preview builds.

  • Screenshot if needed:

  • Any related issues:

Facebook tab active:
screenshot 2017-04-12 11 08 40

BBC tab active:
screenshot 2017-04-12 11 09 00

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.