Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Not all info buttons have tool tip shown #8305

Closed
srirambv opened this issue Apr 13, 2017 · 12 comments
Closed

Not all info buttons have tool tip shown #8305

srirambv opened this issue Apr 13, 2017 · 12 comments
Assignees
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. misc/button polish Nice to have — usually related to front-end/visual tasks. settings

Comments

@srirambv
Copy link
Collaborator

  • Did you search for similar issues before submitting this one?
    Yes

  • Describe the issue you encountered:
    Not all info buttons have tool tip shown

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All

  • Brave Version (revision SHA):
    Brave 0.14.2
    rev d4cad89

  • Steps to reproduce:

    1. Open about:preferences#general, my homepage info has tool tip
    2. Open about:preferences#sync, doesn't have tooltip but shows link at the bottom of page which persists even if navigated to other sections in the same tab after opening the link. Have to rehover over the info button for the link to be dismissed
    3. Open about:preferences#extensions info button is not clickable and neither does the community link shows the link as tool tip
    4. Open about:preferences#plugins info buttons for flash doesn't show tool tip but info buttons for Widevine shows
  • Screenshot if needed:

  • Any related issues:
    Fixed missing content links for info buttons in preferences #5758
    cc: @diracdeltas @bradleyrichter

@srirambv srirambv added design A design change, especially one which needs input from the design team. misc/button polish Nice to have — usually related to front-end/visual tasks. settings labels Apr 13, 2017
@srirambv srirambv added this to the 0.14.3 milestone Apr 13, 2017
@alexwykoff alexwykoff added the needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. label Apr 25, 2017
@alexwykoff
Copy link
Contributor

@srirambv could you re-check this cause i think we just fixed it

@srirambv
Copy link
Collaborator Author

Verified on 0.15.0 RC5. Still no tool tip for info buttons on about:preferences#plugins and info button on about:preferences#extensions is not clickable.

@bbondy bbondy removed this from the 0.15.2 milestone May 2, 2017
@kumarrishav
Copy link
Contributor

@srirambv where tool tip info button should come in about:preferences#plugins case? Next to Plugins Settings header?

@kumarrishav
Copy link
Contributor

kumarrishav commented May 5, 2017

Also, the tool tip icon used in about:preferences#extension is light in color (rgb(101, 101, 101) : mediumGray), while tool tip at other are more black. Is this expected? @bradleyrichter @srirambv

@kumarrishav
Copy link
Contributor

I would like to give this a shot

@kumarrishav kumarrishav self-assigned this May 5, 2017
@kumarrishav
Copy link
Contributor

@srirambv can i get info on this? Thanks

@srirambv
Copy link
Collaborator Author

srirambv commented May 10, 2017

@kumarrishav Flash Plugin info buttons don't have tooltip. Only shown for Google Widewine in plugin page
image

Same with Sync info button no tooltip shown.

First should show tooltip Get Adobe Player
image

Second should show Troubleshooting Flash
image

Sync should show Learn more about Brave Sync
image

Regarding info button on extensions pages, I believe its on purpose as there is link to community given separately at the end. @cezaraugusto or @bradleyrichter can confirm on this for extension page.

@bradleyrichter
Copy link
Contributor

@nickapuzzo Can you review the above and see if it matches your pending doc of string changes?

@kumarrishav
Copy link
Contributor

any update on this one?

@NejcZdovc NejcZdovc modified the milestones: Triage Backlog, Completed work May 7, 2018
@NejcZdovc NejcZdovc added the help wanted The PR/issue opener needs help to complete/report the task. label May 7, 2018
@ntmbayfield
Copy link

Hi, i would like to have this issue assigned to me if possible? I am a student in the Web devlopment Immersive at Galvanize and am looking to contribute to my first open-source project?

@NejcZdovc
Copy link
Contributor

@ntmbayfield Welcome, very happy that you want to contribute to our project. Sadly this issue is already fixed with #13376, but we have a lot of other good stuff.

You can check labels help wanted help wanted The PR/issue opener needs help to complete/report the task. and good first bug bug/good-first-bug .

If you have any more questions or you need some help with the issues just let me know.

@bsclifton bsclifton removed bug/good-first-bug help wanted The PR/issue opener needs help to complete/report the task. needs-investigation A bug not 100% confirmed/fixed that needs QA to better audit. labels May 25, 2018
@jasonrsadler jasonrsadler added the addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. label Aug 13, 2018
@jasonrsadler
Copy link
Contributor

Closing as this should be addressed in Brave-Core

@bsclifton bsclifton removed this from the Completed work milestone Aug 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
addressed-with-brave-core Needs confirmation, but this issue may be resolved with Brave Core. design A design change, especially one which needs input from the design team. misc/button polish Nice to have — usually related to front-end/visual tasks. settings
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants