Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fixed missing content links for info buttons in preferences #5758

Closed
cndouglas opened this issue Nov 21, 2016 · 5 comments · Fixed by #7864
Closed

Fixed missing content links for info buttons in preferences #5758

cndouglas opened this issue Nov 21, 2016 · 5 comments · Fixed by #7864

Comments

@cndouglas
Copy link

cndouglas commented Nov 21, 2016

Original title: Some info buttons in preferences are missing content links #5758 (comment)

Test plan

#7864 (comment)


Did you search for similar issues before submitting this one?
Yes.

Describe the issue you encountered:
There are some info buttons in Preferences > Security, but only two of three are actually clickable. It is confusing because they look the same but work differently. Please see the screenshot below.

My suggestion is to make the clickable buttons actually look like buttons (and look different from the non-clickable one).

Expected behavior:
Clickable elements should be easily distinguishable from non-clickable elements.

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All (found on macOS 10.12.x)

  • Brave Version:
    0.12.9

  • Steps to reproduce:

    1. Open a new Brave window and open Preferences.
    2. Open the Security section.
    3. Look at the "info" buttons (black circles with i) and wonder if they are clickable…
  • Screenshot if needed:
    image

  • Any related issues:
    None.

@cndouglas cndouglas added design A design change, especially one which needs input from the design team. settings labels Nov 21, 2016
@bradleyrichter bradleyrichter changed the title Not obvious that some info buttons in preferences are clickable Some info buttons in preferences are missing content links Nov 23, 2016
@bradleyrichter
Copy link
Contributor

@liunkae These all should have page links so I changed the title.

@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Nov 23, 2016
@bradleyrichter
Copy link
Contributor

@diracdeltas Did we ever add an info page for Flash? I think this could link to your latest helpful flash wiki page.

@bradleyrichter
Copy link
Contributor

#5733

@diracdeltas
Copy link
Member

0.12.10 has the flash wiki link already

@cndouglas
Copy link
Author

Yes, 0.12.10 has the Flash wiki link. The two info buttons in the Plugin Settings section still don't link to anything.
image

diracdeltas added a commit that referenced this issue Mar 23, 2017
fix #5758

Test Plan:
1. go to about:preferences#plugins
2. all the info circle icons should be clickable
@diracdeltas diracdeltas modified the milestones: 0.14.1, 1.0.0 Mar 23, 2017
cezaraugusto pushed a commit that referenced this issue Mar 24, 2017
fix #5758

Test Plan:
1. go to about:preferences#plugins
2. all the info circle icons should be clickable
@luixxiul luixxiul modified the milestones: 0.14.0, 0.14.1 Mar 24, 2017
@bsclifton bsclifton modified the milestones: 0.14.1, 0.14.0 Mar 24, 2017
@alexwykoff alexwykoff changed the title Some info buttons in preferences are missing content links Fixed missing content links for info buttons in preferences Apr 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants