This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

List in redux component #8557

Closed

NejcZdovc opened this issue Apr 28, 2017 · 1 comment

Assignees

Labels

QA/no-qa-needed QA/test-plan-specified refactoring/redux-component release-notes/exclude

Milestone

0.15.300 (Frozen,...

Contributor

NejcZdovc commented Apr 28, 2017 •

edited by luixxiul

Loading

Test plan

#8558 (comment)

Describe the issue you encountered:
We sometimes need to pass in Immutable List into redux component props, because we need to display a list of X items (for example tabs). For that reason we need to do a List check in ReduxComponent.

The text was updated successfully, but these errors were encountered:

NejcZdovc added this to the 0.15.1 milestone

NejcZdovc self-assigned this

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

b0c4e46

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc mentioned this issue

Adds List validation for reduxComponent #8558

Merged

4 tasks

Member

bsclifton commented Apr 28, 2017

Moving to 0.15.2, since 0.15.1 is now a hotfix release 😄

bsclifton modified the milestones: 0.15.2, 0.15.1

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

a315fff

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

578004f

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

ce26a49

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

2686d23

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

82a7641

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc added a commit to NejcZdovc/browser-laptop that referenced this issue


          Improves props validation

18527be

Resolves brave#8557

Auditors: @bridiver

Test Plan:
- create redux component
- pass prop as a simple List
- component should not update if props is the same

NejcZdovc closed this as completed in #8558

NejcZdovc added the QA/no-qa-needed label

luixxiul added QA/test-plan-specified release-notes/exclude and removed QA/no-qa-needed labels

This was referenced May 2, 2017

Per-release issue test for OS X 0.15.3 #8619

Closed

Per release issue test for Windows x64 0.15.2 preview 2 #8620

Closed

Per release issue tests for Linux 0.15.2 preview 2 #8621

Closed

srirambv added the QA/no-qa-needed label

luixxiul added the refactoring/redux-component label

This was referenced May 5, 2017

Manual tests for Windows x64 0.15.3 #8725

Closed

Manual tests for Linux 0.15.3 #8726

Closed

This was referenced May 25, 2017

0.15.3xx OS X RC pass #9035

Closed

0.15.3xx Windows x64 RC run #9036

Closed

0.15.3xx Linux RC run #9037

Closed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.