Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Remove obsolete styles introduced with #2460 #10456

Merged
merged 1 commit into from
Aug 25, 2017
Merged

Remove obsolete styles introduced with #2460 #10456

merged 1 commit into from
Aug 25, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 13, 2017

Addresses #10263

These styles were introduced on ac2e6d1#diff-b6afd5ab48e47aa71ccacf98b2e44c42R49 without direction of usage. It is not possible to detect where they are / have been used. Let's revert it if we'll use those.

Auditors: @cezaraugusto

Test Plan:

  1. Search your repo for type="range"
  2. Make sure nothing is found

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Addresses #10263

These styles were introduced on ac2e6d1#diff-b6afd5ab48e47aa71ccacf98b2e44c42R49 without direction of usage. It is not possible to detect where they are / have been used. Let's revert it if we'll use those.

Auditors: @cezaraugusto

Test Plan:
1. Search your repo for `type="range"`
2. Make sure nothing is found
@luixxiul luixxiul added the polish Nice to have — usually related to front-end/visual tasks. label Aug 13, 2017
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 13, 2017
@luixxiul luixxiul self-assigned this Aug 13, 2017
@luixxiul luixxiul requested a review from cezaraugusto August 13, 2017 09:25
@luixxiul
Copy link
Contributor Author

luixxiul commented Aug 13, 2017

The commit which added those styles is more than 1 year old and the UI have changed drastically since then, so we will need to edit them to re-use them later anyway.

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do have a range input for swipe navigation but not inside sortableTable. Nice find ++

@cezaraugusto cezaraugusto merged commit f4b456a into brave:master Aug 25, 2017
@luixxiul luixxiul deleted the sortableTable-obsolete branch August 25, 2017 07:34
@bbondy bbondy modified the milestones: 0.21.x (Developer Channel), 0.20.x (Beta Channel) Oct 25, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Nice to have — usually related to front-end/visual tasks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants