This repository has been archived by the owner on Dec 11, 2019. It is now read-only.
Consider popupDetail in drag logic #10604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10604 +/- ##
=======================================
Coverage 54.19% 54.19%
=======================================
Files 244 244
Lines 21109 21109
Branches 3258 3258
=======================================
Hits 11440 11440
Misses 9669 9669
|
bsclifton
modified the milestones:
0.19.x (Beta Channel),
0.18.x Hotfix (Release Channel)
bsclifton
approved these changes
Aug 21, 2017
There was a problem hiding this comment.
Confirmed this works great on Windows 10 x64 😄 I ran before/after this patch to ensure the problem was there and this fixed it.
Great job, @jonathansampson! 😄
bsclifton
added a commit
that referenced
this pull request
Aug 21, 2017
Consider popupDetail in drag logic
bsclifton
added a commit
that referenced
this pull request
Aug 21, 2017
Consider popupDetail in drag logic
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitter Checklist:
git rebase -ito squash commits (if needed).Fixes #9436