Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix margin around buttons on certerror.js #10678

Merged
merged 1 commit into from
Sep 5, 2017
Merged

Fix margin around buttons on certerror.js #10678

merged 1 commit into from
Sep 5, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Aug 28, 2017

Fixes #10677

Auditors: @cezaraugusto

Test Plan:

  1. Open https://expired.badssl.com/
  2. Make sure there is a gap between the buttons

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #10677

Auditors: @cezaraugusto

Test Plan:
1. Open https://expired.badssl.com/
2. Make sure there is a gap between the buttons
@luixxiul luixxiul added this to the 0.21.x (Nightly Channel) milestone Aug 28, 2017
@luixxiul luixxiul self-assigned this Aug 28, 2017
@luixxiul luixxiul requested a review from cezaraugusto August 28, 2017 02:02
@luixxiul luixxiul modified the milestones: 0.19.x (Beta Channel), 0.21.x (Nightly Channel) Aug 28, 2017
@luixxiul
Copy link
Contributor Author

Setting the milestone to 0.19 as the regression has been introduced with 3dfc598#diff-0ff973318abdc5c07f55cefe86bd5ed7R109.

Copy link
Contributor

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 739ca53 into brave:master Sep 5, 2017
@cezaraugusto cezaraugusto deleted the polish-certError branch September 5, 2017 03:56
@luixxiul
Copy link
Contributor Author

luixxiul commented Sep 5, 2017

@cezaraugusto would you mind adding the commit to 0.19.x and 0.20.x? thanks!

@cezaraugusto
Copy link
Contributor

yup doing now

cezaraugusto added a commit that referenced this pull request Sep 5, 2017
Fix margin around buttons on certerror.js
cezaraugusto added a commit that referenced this pull request Sep 5, 2017
Fix margin around buttons on certerror.js
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants