Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Fix siteInfo dialog width bug #10931

Merged
merged 1 commit into from
Sep 13, 2017
Merged

Fix siteInfo dialog width bug #10931

merged 1 commit into from
Sep 13, 2017

Conversation

luixxiul
Copy link
Contributor

@luixxiul luixxiul commented Sep 13, 2017

Fixes #10930

Auditors:

Test Plan:

  1. Open https://mixed-script.badssl.com/
  2. Click the lock icon
  3. Make sure the width of dialog is 500px

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.

Test Plan:

Reviewer Checklist:

Tests

  • Adequate test coverage exists to prevent regressions
  • Tests should be independent and work correctly when run individually or as a suite ref
  • New files have MPL2 license header

Fixes #10930

Auditors:

Test Plan:
1. Open https://mixed-script.badssl.com/
2. Click the lock icon
3. Make sure the width of dialog is 500px
@luixxiul luixxiul added this to the 0.19.x (Beta Channel) milestone Sep 13, 2017
@luixxiul luixxiul self-assigned this Sep 13, 2017
@luixxiul luixxiul requested a review from bsclifton September 13, 2017 15:20
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@NejcZdovc NejcZdovc merged commit fa1d595 into brave:master Sep 13, 2017
@luixxiul luixxiul deleted the polish-siteInfo branch September 13, 2017 15:25
@NejcZdovc
Copy link
Contributor

NejcZdovc commented Sep 13, 2017

master f39ba1f
0.20.x 8aca32f
0.19.x f0f13d0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants