Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

fix bad tab page preview while closing tabs #11768

Merged
merged 1 commit into from
Nov 8, 2017
Merged

fix bad tab page preview while closing tabs #11768

merged 1 commit into from
Nov 8, 2017

Conversation

cezaraugusto
Copy link
Contributor

@cezaraugusto cezaraugusto commented Nov 2, 2017

fix #11632

Note for reviewers: There are some bad tab page functionality happening for latest versions so while this works on master it's better tested in 0.19.x

My take is that w/ previous timeout made tab page previews to happen unintentionally. I couldn't reproduce the bug again w/ this fix. No need to timeout for tab pages which was a copy of old preview mechanism for tabs.

Test plan (better tested in 0.19.x):

  1. Open 3 tab pages
  2. Sequentially close tabs
  3. No tab preview should be triggered

@codecov-io
Copy link

codecov-io commented Nov 2, 2017

Codecov Report

Merging #11768 into master will increase coverage by 0.02%.
The diff coverage is 50%.

@@            Coverage Diff             @@
##           master   #11768      +/-   ##
==========================================
+ Coverage   52.75%   52.78%   +0.02%     
==========================================
  Files         269      269              
  Lines       25668    25653      -15     
  Branches     4097     4093       -4     
==========================================
- Hits        13542    13541       -1     
+ Misses      12126    12112      -14
Flag Coverage Δ
#unittest 52.78% <50%> (+0.02%) ⬆️
Impacted Files Coverage Δ
js/actions/windowActions.js 4.9% <ø> (+0.04%) ⬆️
js/stores/windowStore.js 27.01% <0%> (ø) ⬆️
js/state/frameStateUtil.js 64.48% <66.66%> (+1.46%) ⬆️

@bbondy bbondy merged commit fe9a065 into master Nov 8, 2017
bbondy added a commit that referenced this pull request Nov 8, 2017
fix bad tab page preview while closing tabs
bbondy added a commit that referenced this pull request Nov 8, 2017
fix bad tab page preview while closing tabs
bbondy added a commit that referenced this pull request Nov 8, 2017
fix bad tab page preview while closing tabs
@bbondy
Copy link
Member

bbondy commented Nov 8, 2017

master: fe9a065
0.21.x: a3e71e6
0.20.x: b4cfefc
0.19.x: 3b9daa1

@bbondy
Copy link
Member

bbondy commented Nov 9, 2017

Backed out here:
master: 06e535c
0.21.x: a604752
0.20.x: 1c8d5e5
0.19.x: 340e4e5

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After closing a tab when multiple tab pages are present, tab bar doesn't always leave preview mode
4 participants